Open
Bug 1499180
Opened 6 years ago
Updated 2 years ago
Avoid first SIGSEGV in debugger in local developer builds
Categories
(Firefox Build System :: Android Studio and Gradle Integration, defect, P3)
Firefox Build System
Android Studio and Gradle Integration
Tracking
(firefox66 fix-optional, firefox67 ?)
NEW
Tracking | Status | |
---|---|---|
firefox66 | --- | fix-optional |
firefox67 | --- | ? |
People
(Reporter: nalexander, Unassigned)
References
(Blocks 1 open bug)
Details
(Whiteboard: [geckoview:p3])
When running a GeckoView-consuming application in a native debugger, a SIGSEGV is generated and then immediately trapped around https://searchfox.org/mozilla-central/rev/c9272ef398954288525e37196eada1e5a93d93bf/mozglue/linker/ElfLoader.cpp#1393. Unfortunately in a native debugger, this is pretty frustrating -- you need to manually continue through the SIGSEGV.
snorp tells me that this can be avoided in some builds. Presumably, it is safe to skip the check in builds where DEVELOPER_OPTIONS is set. Since the check is a function of the device and Android OS, it shouldn't change much (really, at all) over time on a fixed device.
Reporter | ||
Comment 1•6 years ago
|
||
snorp: is my understanding of the situation here accurate? This would be a nice papercut to avoid.
Flags: needinfo?(snorp)
Yup, sounds right. I was thinking we'd only do the check on official builds, but DEVELOPER_OPTIONS could be ok too.
Flags: needinfo?(snorp)
Comment 3•6 years ago
|
||
Practically speaking, we don't care about the latency test anymore. The "SignalHandlingBroken" case is more interesting. It makes us disable the segfault handler entirely afterwards, which means if a device has SignalHandlingBroken *and* has a system library registering its own segfault handler, then we may actually have problems with the asmjs segfault handler on those devices.
That said, I'm not sure we still actually benefit from registering our segfault handler at all. I'd need to do some archeology to see what exact kind of problem it worked around and whether they would apply to the asmjs segfault handler.
Updated•6 years ago
|
Priority: -- → P3
Whiteboard: [geckoview] → [geckoview:p3]
Updated•5 years ago
|
Product: Firefox for Android → Firefox Build System
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•