Closed
Bug 1499394
Opened 6 years ago
Closed 5 years ago
Refactor PromptDelegate/PermissionDelegate to use GeckoResult rather than callbacks
Categories
(GeckoView :: General, enhancement, P3)
Tracking
(firefox69 wontfix, firefox70 fixed)
RESOLVED
FIXED
mozilla70
People
(Reporter: droeh, Assigned: droeh)
Details
Attachments
(3 files, 1 obsolete file)
Refactoring PromptDelegate and PermissionDelegate to use GeckoResults rather than callbacks will bring them more in line with the rest of the API.
|
||
Updated•6 years ago
|
Priority: -- → P3
|
||
Updated•6 years ago
|
Product: Firefox for Android → GeckoView
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
Depends on D40682
|
|
Assignee | |
Comment 4•5 years ago
|
||
Depends on D40683
|
||
Updated•5 years ago
|
Attachment #9082689 -
Attachment is obsolete: true
Pushed by droeh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/77fa1072f8a8
[1.0] Kill off old PromptDelegate, PromptCallback, and handlePromptEvent. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/438452cc4e22
[2.0] Add new PromptDelegate and handlePromptEvent. r=geckoview-reviewers,snorp,rbarker
https://hg.mozilla.org/integration/autoland/rev/595a0c78c402
[3.0] Update tests, BasicGeckoViewActivity, and CHANGELOG around PromptDelegate changes. r=geckoview-reviewers,snorp
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/77fa1072f8a8
https://hg.mozilla.org/mozilla-central/rev/438452cc4e22
https://hg.mozilla.org/mozilla-central/rev/595a0c78c402
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
|
||
Comment 7•5 years ago
|
||
69=wontfix because I assume we don't need to uplift this PromptDelegate/PermissionDelegate refactoring to GV 69 Beta.
status-firefox69:
--- → wontfix
You need to log in
before you can comment on or make changes to this bug.
Description
•