Closed
Bug 1499615
Opened 6 years ago
Closed 6 years ago
side_effect_free: Calling ++this->mSetSinkRequestsCount is only useful for its return value, which is ignored.
Categories
(Core :: Audio/Video: Playback, defect, P2)
Core
Audio/Video: Playback
Tracking
()
VERIFIED
FIXED
mozilla64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: achronop)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: [CID 1440248])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Introduced in bug 934425, coverity says that
https://searchfox.org/mozilla-central/source/dom/media/MediaDecoderStateMachine.cpp#3677
is useless.
Reporter | ||
Updated•6 years ago
|
Flags: needinfo?(achronop)
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
After doing all the setup and generating the report, I found out that this is the coverage tool something else from coverity tool. Coverity is a static analysis tool. There's no way to test a coverity fix right now. I have to land it and wait for the next coverity build to confirm.
Andreas, given that, are you ok to land this patch as is?
Flags: needinfo?(achronop)
Reporter | ||
Comment 3•6 years ago
|
||
yeah, it will work!
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → achronop
Pushed by achronopoulos@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cf707f5b0477
Silence unused returned value warning and initialize the counter. r=pehrsons
Updated•6 years ago
|
Priority: -- → P2
Comment 5•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Reporter | ||
Comment 6•6 years ago
|
||
I confirmed that the issue is marked as fixed by coverity. Thanks!
Status: RESOLVED → VERIFIED
Assignee | ||
Comment 7•6 years ago
|
||
Thanks for looking at it Sylvestre!
You need to log in
before you can comment on or make changes to this bug.
Description
•