Closed
Bug 1499947
Opened 6 years ago
Closed 6 years ago
kill xul:progressmeter
Categories
(Core :: XUL, task, P1)
Core
XUL
Tracking
()
RESOLVED
FIXED
mozilla65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: surkov, Assigned: Paolo)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
Attachments
(2 files)
as long as bug 1428869 is fixed, we can kill progressmeter CE (see bug 1491197).
So
* rollback bug 1491197
* remove all XULProgressMeterAccessible references https://searchfox.org/mozilla-central/search?q=XULProgressMeterAccessible&case=true&path=
* remove <progressmeter> from XUL testing files https://searchfox.org/mozilla-central/search?q=%3Cprogressmeter&case=true&path=*.xul
Reporter | ||
Updated•6 years ago
|
Summary: kill progressmeter CE → kill xul:progressmeter
Assignee | ||
Comment 1•6 years ago
|
||
There's also the XUL frame and some appearance code that looks for XUL attributes.
Assignee | ||
Updated•6 years ago
|
Blocks: war-on-xbl
Updated•6 years ago
|
Priority: -- → P4
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Priority: P4 → P1
Assignee | ||
Comment 3•6 years ago
|
||
Depends on D12143
Assignee | ||
Comment 4•6 years ago
|
||
Depends on D12144
Assignee | ||
Comment 6•6 years ago
|
||
Assignee | ||
Comment 7•6 years ago
|
||
Assignee | ||
Comment 8•6 years ago
|
||
When this lands, uses of the XUL "progressmeter" in comm-central would have to be replaced with the HTML "progress" element, or the current Custom Element could be moved there.
Flags: needinfo?(jorgk)
Comment 9•6 years ago
|
||
Thanks for the heads-up. I thought we had already replaced all progress metres with HTML in bug 1499593. I'm not missing anything here, am I, Richard?
Flags: needinfo?(jorgk) → needinfo?(richard.marti)
Assignee | ||
Comment 10•6 years ago
|
||
Is this returning stale results?
https://dxr.mozilla.org/comm-central/search?q=%3Cprogressmeter
Comment 11•6 years ago
|
||
(In reply to :Paolo Amadini from comment #10)
> Is this returning stale results?
>
> https://dxr.mozilla.org/comm-central/search?q=%3Cprogressmeter
The footer says last updated at 2018-11-19 22:51.
Better to use https://searchfox.org/comm-central/search?q=%3Cprogressmeter&case=false®exp=false&path=
Which shows only one <progressmeter which landed in bug 1496632 after our port to html. So only this needs to be fixed.
Flags: needinfo?(richard.marti)
Updated•6 years ago
|
Comment 12•6 years ago
|
||
Thanks again, I wasn't aware of the last one which had crept in. Filed bug 1508735 for its removal.
Comment 13•6 years ago
|
||
Pushed by paolo.mozmail@amadzone.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f64862fa1c3
Part 1 - Remove XULProgressMeterAccessible and its base template class. r=Jamie
https://hg.mozilla.org/integration/mozilla-inbound/rev/82e8d51e41a5
Part 2 - Remove the "progressmeter" element and related tests. r=bgrins,bzbarsky
Comment 14•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0f64862fa1c3
https://hg.mozilla.org/mozilla-central/rev/82e8d51e41a5
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Updated•5 years ago
|
Type: enhancement → task
You need to log in
before you can comment on or make changes to this bug.
Description
•