Closed Bug 1499962 Opened 6 years ago Closed 6 years ago

Green up wpt netinfo directory on fennec

Categories

(Testing :: web-platform-tests, defect)

Version 3
defect
Not set
normal

Tracking

(firefox65 fixed)

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: KWierso, Assigned: KWierso)

References

Details

Attachments

(1 file)

There are a lot of UNEXPECTED PASSes, and I lone FAIL (which looks related to the unexpected passes): Unexpected Results ------------------ /netinfo/idlharness.any.worker.html UNEXPECTED-PASS NetworkInformation interface: existence and properties of interface object UNEXPECTED-PASS NetworkInformation interface object length UNEXPECTED-PASS NetworkInformation interface object name UNEXPECTED-PASS NetworkInformation interface: existence and properties of interface prototype object UNEXPECTED-PASS NetworkInformation interface: existence and properties of interface prototype object's "constructor" property UNEXPECTED-PASS NetworkInformation interface: existence and properties of interface prototype object's @@unscopables property UNEXPECTED-PASS NetworkInformation interface: attribute type UNEXPECTED-PASS NetworkInformation must be primary interface of navigator.connection UNEXPECTED-PASS Stringification of navigator.connection UNEXPECTED-PASS NetworkInformation interface: navigator.connection must inherit property "type" with the proper type FAIL Navigator interface: navigator must not have property "connection" - assert_false: expected false got true IdlInterface.prototype.test_interface_of/<@http://web-platform.test:8000/resources/idlharness.js:2587:17 Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1561:20 test@http://web-platform.test:8000/resources/testharness.js:544:21 self.subsetTestByKey@http://web-platform.test:8000/resources/idlharness.js:54:14 IdlInterface.prototype.test_interface_of@http://web-platform.test:8000/resources/idlharness.js:2585:13 IdlInterface.prototype.test_object@http://web-platform.test:8000/resources/idlharness.js:2503:9 IdlArray.prototype.test/<@http://web-platform.test:8000/resources/idlharness.js:826:36 IdlArray.prototype.test@http://web-platform.test:8000/resources/idlharness.js:821:13 idl_test/</<@http://web-platform.test:8000/resources/idlharness.js:3122:21 UNEXPECTED-PASS WorkerNavigator interface: attribute connection /netinfo/idlharness.any.html UNEXPECTED-PASS NetworkInformation interface: existence and properties of interface object UNEXPECTED-PASS NetworkInformation interface object length UNEXPECTED-PASS NetworkInformation interface object name UNEXPECTED-PASS NetworkInformation interface: existence and properties of interface prototype object UNEXPECTED-PASS NetworkInformation interface: existence and properties of interface prototype object's "constructor" property UNEXPECTED-PASS NetworkInformation interface: existence and properties of interface prototype object's @@unscopables property UNEXPECTED-PASS NetworkInformation interface: attribute type UNEXPECTED-PASS NetworkInformation must be primary interface of navigator.connection UNEXPECTED-PASS Stringification of navigator.connection UNEXPECTED-PASS NetworkInformation interface: navigator.connection must inherit property "type" with the proper type UNEXPECTED-PASS Navigator interface: attribute connection UNEXPECTED-PASS Navigator interface: navigator must inherit property "connection" with the proper type /netinfo/netinfo-basics.html UNEXPECTED-PASS type attribute
Marcos, do you know if we should just update the expectation metadata for these tests on fennec? I'm not sure if this is just a feature that fennec supports while desktop Firefox doesn't or if there's something actually broken in these tests on fennec.
Flags: needinfo?(mcaceres)
(In reply to Wes Kocher (:KWierso) from comment #1) > Marcos, do you know if we should just update the expectation metadata for > these tests on fennec? Yes. We should do that, given that we support it. > I'm not sure if this is just a feature that fennec > supports while desktop Firefox doesn't or if there's something actually > broken in these tests on fennec. This is indeed a Fennec only feature - so I think it should be fine to update the metadata as expected pass *only* on Fennec.
Flags: needinfo?(mcaceres)
Fennec actually supports this API, so the tests pass on fennec while they fail on desktop.
Assignee: nobody → wkocher
Pushed by wkocher@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5173779c1c5e update wpt metadata for netinfo tests on fennec r=marcosc
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Comment on attachment 9018634 [details] Bug 1499962 - update wpt metadata for netinfo tests on fennec r?marcosc Setting to r+ here too, because Bugzilla and Phabricator didn't sync.
Attachment #9018634 - Flags: review?(mcaceres) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: