Closed
Bug 1500079
Opened 6 years ago
Closed 6 years ago
Ensure that openAboutDebugging test helper waits for initialization before resolving
Categories
(DevTools :: about:debugging, enhancement, P2)
DevTools
about:debugging
Tracking
(firefox65 fixed)
RESOLVED
FIXED
Firefox 65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
(Whiteboard: dt-fission)
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
openAboutDebugging helper:
https://searchfox.org/mozilla-central/rev/eef79962ba73f7759fd74da658f6e5ceae0fc730/devtools/client/aboutdebugging-new/test/browser/head.js#27-43
only waits for a couple of DOM elements to be created before resolving.
But ideally, it should wait for full initialization before resolving.
Otherwise, you would get failures like I got in bug 1485661, where RDP requests being made during initialization are still pending on test end. Or you may have unexpected behavior as initialization is still processing while your test script executes.
There is a couple of ways to better wait for full initialization.
* From AboutDebugging.init, we could "await" for all the dispatches actions, like these two:
https://searchfox.org/mozilla-central/rev/eef79962ba73f7759fd74da658f6e5ceae0fc730/devtools/client/aboutdebugging-new/aboutdebugging.js#62-63
And have the test helper somehow wait for AboutDebugging.init resolution.
* We could use the existing "waitUntilState" helper, and explicitely wait for a couple of expected states from openAboutDebugging function.
* There propably is some other options...
Assignee | ||
Comment 1•6 years ago
|
||
MozReview-Commit-ID: 9ClZ2lkdq01
Depends on D8868
Assignee | ||
Comment 2•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Whiteboard: dt-fission
Assignee | ||
Comment 3•6 years ago
|
||
Green try for the latest version:
https://hg.mozilla.org/try/rev/9e63cb4e5fefa1d606cc68d2705456e74d5f7d95
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e732689cf7e7
Ensure that new about:debugging tests wait for initial load requests before proceeding with the tests. r=jdescottes
Comment 5•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in
before you can comment on or make changes to this bug.
Description
•