Closed Bug 1500314 Opened 6 years ago Closed 6 years ago

Consider dropping use of gfxPrefs::DesktopViewportWidth in nsIDocument::GetViewportInfo for a fallback value

Categories

(Core :: Layout, enhancement, P1)

Product:
Core
Component:
Layout
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox64 --- wontfix
firefox68 --- fixed

People

(Reporter: hiro, Assigned: bradwerth)

References

Details

(Whiteboard: [rdm-mvp])

Attachments

(2 files)

Bug 1500314 Part 1: Only apply mobile viewport stretching for documents with no meta viewport tag.
(deleted), text/x-phabricator-request
Details
Bug 1500314 Part 2: Update test expectations.
(deleted), text/x-phabricator-request
Details
Here https://hg.mozilla.org/mozilla-central/file/6c55991a052e/dom/base/nsDocument.cpp#l7423 Currently the value is used when neither width and height is not specified in meta viewport, but in such cases we should use the screen width as per the spec [1] [1] https://drafts.csswg.org/css-device-adapt/#resolve-width

This is the root cause of Bug 1501665, which has steps to reproduce.

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE

The patches for Bug 1501665 are no longer resolving this issue, so I'm re-opening the bug. I have a patch that I'll post to this bug, and I'll add tests after Bug 1501665 lands.

Assignee: nobody → bwerth
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=1501665

But to clarify, this shouldn't apply to pages that don't have any <meta> viewport tag at all (see here for a little more details).

If I'm translating the CSS-logic correctly to <meta> viewport, doing that would also approximately correspond to what is termed "Small screen UA styles" in the spec.

Yep, I think we're in agreement here -- what we're looking to land in this bug is the revised version of this patch, not the original version.

Might also be an opportunity to make https://phabricator.services.mozilla.com/D20953 do what I originally claimed it to do then, i.e. really evaluate UseWidthDeviceWidthFallbackViewport() only when the <meta> viewport tag is completely missing.

Depends on D23531

Pushed by bwerth@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/77cafd05c85c Part 1: Only apply mobile viewport stretching for documents with no meta viewport tag. r=botond https://hg.mozilla.org/integration/autoland/rev/38349ca764d7 Part 2: Update test expectations. r=botond

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=38349ca764d764d99930bd94ae088072a4d93d1d&searchStr=android&selectedJob=235575458

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=235575458&repo=autoland&lineNumber=1688

Backout link: https://hg.mozilla.org/integration/autoland/rev/62b9000a17c10b9ba87adc94772a8679491d2514

task 2019-03-22T23:04:56.297Z] 23:04:56 INFO - 150 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_bug982141.html | expected at least one paint in compositor test data
[task 2019-03-22T23:04:56.298Z] 23:04:56 INFO - Buffered messages finished
[task 2019-03-22T23:04:56.298Z] 23:04:56 INFO - 151 INFO TEST-UNEXPECTED-FAIL | gfx/layers/apz/test/mochitest/test_bug982141.html | found the RCD node
[task 2019-03-22T23:04:56.299Z] 23:04:56 INFO - SimpleTest.ok@SimpleTest/SimpleTest.js:275:18
[task 2019-03-22T23:04:56.299Z] 23:04:56 INFO - testBug982141@gfx/layers/apz/test/mochitest/helper_bug982141.html:54:18
[task 2019-03-22T23:10:13.023Z] 23:10:13 INFO - 152 INFO TEST-UNEXPECTED-FAIL | gfx/layers/apz/test/mochitest/test_bug982141.html | Test timed out.
[task 2019-03-22T23:10:13.024Z] 23:10:13 INFO - SimpleTest.ok@SimpleTest/SimpleTest.js:275:18
[task 2019-03-22T23:10:13.024Z] 23:10:13 INFO - reportError@SimpleTest/TestRunner.js:121:22
[task 2019-03-22T23:10:13.024Z] 23:10:13 INFO - TestRunner._checkForHangs@SimpleTest/TestRunner.js:142:7

Flags: needinfo?(bwerth)
Status: REOPENED → ASSIGNED
Priority: P3 → P1
Whiteboard: [rdm-mvp]
https://hg.mozilla.org/projects/ash/rev/77cafd05c85c01998b90fac9d87e924040de1a90 Bug 1500314 Part 1: Only apply mobile viewport stretching for documents with no meta viewport tag. r=botond
Pushed by bwerth@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/55b2341d41d3 Part 1: Only apply mobile viewport stretching for documents with no meta viewport tag. r=botond https://hg.mozilla.org/integration/autoland/rev/3054d8c5618f Part 2: Update test expectations. r=botond

https://hg.mozilla.org/mozilla-central/rev/55b2341d41d3
https://hg.mozilla.org/mozilla-central/rev/3054d8c5618f

Status: ASSIGNED → RESOLVED
Closed: 6 years ago → 6 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Flags: needinfo?(bwerth)
Regressions: 1552713
Regressions: 1556275
Regressions: 1564021
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: