Closed Bug 1500632 Opened 6 years ago Closed 6 years ago

source-map-url-service does not trigger subscribers that were added before the script was detected

Categories

(DevTools :: Console, defect)

defect
Not set
normal

Tracking

(firefox65 fixed)

RESOLVED FIXED
Firefox 65
Tracking Status
firefox65 --- fixed

People

(Reporter: loganfsmyth, Assigned: loganfsmyth)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Tracked down as the cause of https://github.com/devtools-html/debugger.html/issues/6923. source-map-url-service allows callers to register subscribers, but in this case the console is actually calling `.subscribe` before the URL service has received the "source-updated" event that makes it aware of the script in the first place. To avoid this race condition, it seems like `source-updated` events should also be sure to trigger any subscribers that have been added for the file.
Blocks: source-maps
Pushed by lsmyth@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f3d51256c5d7 source-map-url-service should trigger subscribers when files matching them are detected. r=tromey
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: