Closed
Bug 1500881
Opened 6 years ago
Closed 6 years ago
WindowEventManager uses deprecated EventManager constructor
Categories
(Thunderbird :: Add-Ons: Extensions API, defect)
Tracking
(thunderbird64 fixed, thunderbird65 fixed)
RESOLVED
FIXED
Thunderbird 65.0
People
(Reporter: neil, Assigned: darktrojan)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
darktrojan
:
review+
jorgk-bmo
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
Comment on attachment 8988432 [details] [diff] [review]
1455471-webext-windowstabs-2.diff
>+global.WindowEventManager = class extends EventManager {
>+ constructor(context, name, event, listener) {
>+ super(context, name, fire => {
ESR60 syntax (wrong for this trunk patch!)
>+ super({
>+ context,
>+ name: "tabs.onUpdated",
>+ register,
>+ });
Correct trunk syntax.
|
||
Comment 1•6 years ago
|
||
Geoff, can you please take care of this.
Neil, thanks for filing!
Flags: needinfo?(geoff)
|
Assignee | |
Comment 2•6 years ago
|
||
I've also converted both our subclasses to the same format.
Assignee: nobody → geoff
Status: NEW → ASSIGNED
Flags: needinfo?(geoff)
Attachment #9019173 -
Flags: review?(jorgk)
|
|
||
Comment 3•6 years ago
|
||
Comment on attachment 9019173 [details] [diff] [review]
1500881-event-manager-1.diff
All I can do here is pattern matching. Let's get a qualified review. Or perhaps ask Neil who detected it.
Attachment #9019173 -
Flags: review?(jorgk) → review?(mkmelin+mozilla)
|
||
Comment 4•6 years ago
|
||
Comment on attachment 9019173 [details] [diff] [review]
1500881-event-manager-1.diff
Review of attachment 9019173 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM thx! r=mkmelin
::: mail/components/extensions/parent/ext-mail.js
@@ +185,5 @@
> + constructor({ context, name, event, listener }) {
> + super({
> + context,
> + name,
> + listener: fire => {
nit: I think it's clearer for readability to put parenthesis around (fire)
Attachment #9019173 -
Flags: review?(mkmelin+mozilla) → review+
|
|
Assignee | |
Comment 5•6 years ago
|
||
Attachment #9019173 -
Attachment is obsolete: true
Attachment #9019289 -
Flags: review+
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/02352ad526d3
Use new EventManager constructor. r=mkmelin
|
|
||
Comment 7•6 years ago
|
||
Comment on attachment 9019289 [details] [diff] [review]
1500881-event-manager-2.diff
I guess this needs beta uplift. What exactly didn't work? Or would that have only be noticeable with a WebExtension?
Attachment #9019289 -
Flags: approval-comm-beta+
|
|
||
Updated•6 years ago
|
Target Milestone: --- → Thunderbird 65.0
|
|
||
Comment 8•6 years ago
|
||
status-thunderbird64:
--- → fixed
status-thunderbird65:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•