Closed
Bug 1500963
Opened 6 years ago
Closed 6 years ago
Pass a `renderStacktrace` prop to Reps
Categories
(DevTools :: Console, enhancement, P1)
DevTools
Console
Tracking
(firefox65 fixed)
RESOLVED
FIXED
Firefox 65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
References
Details
(Whiteboard: [boogaloo-mvp])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
In Bug 1390768, we are probably going to end up creating a new component that will wrap debugger's Frames component. This component will be used by the console and other panels (netmonitor, …), but it would be also good to allow Reps that display a trace (i.e. Errors) to have access to this component. The idea would be to pass a `renderStacktrace` function that would render the stacktrace with the new component. This way, all the stacktraces displayed in devtools would be the same (and handle sourcemap).
Assignee | ||
Updated•6 years ago
|
Whiteboard: [boogaloo-mvp]
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 1•6 years ago
|
||
This also depends on https://github.com/devtools-html/debugger.html/issues/7130
Assignee | ||
Comment 2•6 years ago
|
||
Removing dependency on Bug 1390768 since we can already use the Stacktrace component in renderStacktrace. Still need the next version of reps though.
Assignee | ||
Comment 3•6 years ago
|
||
This patch makes use of the new renderStacktrace prop in Reps to render Error objects stacktraces using the shared Stacktrace component. This way we are showing stacktraces in a consistent way, and as a bonus, we support sourcemap in Error object. Depends on D9922
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/006509a8370f Use the Stacktrace component in Error reps; r=bgrins.
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/006509a8370f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in
before you can comment on or make changes to this bug.
Description
•