Closed Bug 1500987 Opened 6 years ago Closed 6 years ago

Elevate the new debugger one directory

Categories

(DevTools :: Debugger, enhancement, P3)

Product:
DevTools
Component:
Debugger
Type:
enhancement

Tracking

(firefox68 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: davidwalsh, Assigned: davidwalsh)

References

Details

Attachments

(2 files, 3 obsolete files)

1500987-2.patch
(deleted), patch
ochameau
: review+
Details | Diff | Splinter Review
1500987-1.patch
(deleted), patch
Details | Diff | Splinter Review
Once the old tests are moved to shared/, we should elevate the debugger one directory level so that it lives right in debugger, not debugger/new
Priority: -- → P3
Attached patch 1500987-1.patch (obsolete) (deleted) — — Splinter Review

This PR removes the old moz.build so that a move of the same file in the /new directory wont break history.

Assignee: nobody → dwalsh
Attachment #9038895 - Flags: review?(poirot.alex)
Attached patch 1500987-2.patch (deleted) — — Splinter Review

This is the large file move and changing of references to the new location. (i.e. remove /new from a bunch of strings.

Attachment #9038896 - Flags: review?(poirot.alex)
Comment on attachment 9038896 [details] [diff] [review] 1500987-2.patch Review of attachment 9038896 [details] [diff] [review]: ----------------------------------------------------------------- You are missing the following ocurrences: https://searchfox.org/mozilla-central/source/devtools/client/shared/components/SmartTrace.css#138 https://searchfox.org/mozilla-central/source/toolkit/content/license.html#2806 (there is more than one occurence in this html file) https://searchfox.org/mozilla-central/source/testing/talos/talos/tests/devtools/addon/content/tests/debugger/debugger-helpers.js#12 Otherwise, I had to manually move reload.svg and FrameIndent.js, but I imagine that's a rebase issue. Sorry about the delay in reviewing this patch, hopefully the rebase will be trivial for you. Thanks a lot for finishing the move!!
Attachment #9038896 - Flags: review?(poirot.alex) → review+
Attachment #9038895 - Flags: review?(poirot.alex) → review+
Blocks: 1314057

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:davidwalsh, could you have a look please?

Flags: needinfo?(dwalsh)

Unfortunately these require a massive rebase which I hope to get to soon.

Flags: needinfo?(dwalsh)
Attachment #9056603 - Attachment is obsolete: true
Attachment #9056599 - Attachment is obsolete: true
Attached patch 1500987-1.patch (deleted) — — Splinter Review
Attachment #9038895 - Attachment is obsolete: true
Pushed by jlaster@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/21e7aa527584 Elevate the new debugger one directory. r=jlast
Pushed by jlaster@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ca42d5764b08 Elevate the new debugger one directory. r=jlast
Pushed by jlaster@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e9408a26af67 Elevate the new debugger one directory. r=jlast

https://hg.mozilla.org/mozilla-central/rev/e9408a26af67

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Flags: needinfo?(dwalsh)
Flags: needinfo?(jlaster)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: