Closed
Bug 1501170
Opened 6 years ago
Closed 6 years ago
<csc-input default-value="…"> isn't implemented; Security Code no longer populated on summary page after adding
Categories
(Firefox :: WebPayments UI, defect, P1)
Firefox
WebPayments UI
Tracking
()
VERIFIED
FIXED
Firefox 65
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox63 | --- | unaffected |
firefox64 | --- | disabled |
firefox65 | --- | verified |
People
(Reporter: MattN, Assigned: jaws)
References
()
Details
(Keywords: regression, Whiteboard: [webpayments])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Bug 1470199 implemented the observed attribute for @default-value but didn't do anything with it so it's dead code. This regressed the previous behaviour where .defaultValue was set on the plain <input>. When a card is added from the dialog, the CSC/CVV is no longer also populated on the summary page.
STR:
1) Add a card from the dialog; include the CVV/CSC (either in the FTU or not)
2) Click Save/Next to return to the summary page
Expected result:
CSC/CVV field on the summary page has the value just entered on the add page
Actual result:
CSC/CVV field is blank
I think the main fix is:
render() {
+ this._input.defaultValue = this.defaultValue || "";
if (this.value) {
but I think the @value handling should be reviewed and a test will be needed.
Flags: qe-verify+
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Updated•6 years ago
|
Priority: P2 → P1
Assignee | ||
Comment 1•6 years ago
|
||
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bcf4e23132eb
Render the defaultValue in the CSC input if one has been provided. r=MattN
Comment 3•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Comment 4•6 years ago
|
||
CSC/CVV field on the summary page has the value entered on the "Add Credit Card" page on Firefox Nightly 65.0a1 (2018-11-14) on Windows 10 x 64, Windows 7 x32, Mac OS X 10.13 and on Ubuntu 16.04 x64.
But shouldn't the CVV be reset after selecting another payment method from the drop down?
Flags: needinfo?(jaws)
Reporter | ||
Comment 5•6 years ago
|
||
(In reply to Hani Yacoub from comment #4)
> But shouldn't the CVV be reset after selecting another payment method from
> the drop down?
The plan is to select (highlight) the CVV text so that the user can type over it if they want but it's possible they typed the correct CVV before using the picker so we don't want to clear it automatically. We have bug 1472712 on file for that already.
Flags: needinfo?(jaws)
Comment 6•6 years ago
|
||
Got it! Thanks.
You need to log in
before you can comment on or make changes to this bug.
Description
•