Closed
Bug 1501341
Opened 6 years ago
Closed 6 years ago
File icons should inherit text color
Categories
(DevTools :: Netmonitor, enhancement, P3)
DevTools
Netmonitor
Tracking
(firefox65 fixed)
RESOLVED
FIXED
Firefox 65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: fvsch, Assigned: jens1o, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: good-first-bug, )
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
The file icons implemented in bug 1356536 are always black. This makes them hard to see in two situations: 1. Dark theme (black icon on dark gray background) 2. Selected row (black icon on dark blue background) We probably need to pass them the current text color as a context-fill. Fix would look like, in SVG: <path fill="context-fill #0b0b0b" d="..."/> And in CSS: -moz-context-properties: fill; fill: currentColor;
Updated•6 years ago
|
Assignee | ||
Comment 1•6 years ago
|
||
I'd like to take this. Do I only need to clone debugger.html or the hole Firefox repository?
Flags: needinfo?(odvarko)
Comment 2•6 years ago
|
||
(In reply to Jens Hausdorf :jens1o [ni? me] from comment #1) > I'd like to take this. ok, great! > Do I only need to clone debugger.html or the hole > Firefox repository? This bug is related to the Network panel (not debugger), so you need to clone entire Firefox repo: hg clone https://hg.mozilla.org/mozilla-central/ firefox Read more: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Source_Code/Mercurial Honza
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
Flags: needinfo?(odvarko)
Priority: -- → P3
Reporter | ||
Comment 3•6 years ago
|
||
Since this will be only frontend changes, you can work with artifact builds. And to see your changes, after the first build you probably only need to close and reopen DevTools (instead of rebuilding). I advise reading this whole page: https://docs.firefox-dev.tools/getting-started/build.html
Assignee | ||
Comment 4•6 years ago
|
||
The original implementation didn't took into account that the icons are hardly visible when either using a dark theme or hovering over the row.
Assignee | ||
Comment 5•6 years ago
|
||
This is my first use with arc and phabricator. Please let me know if I did anything wrong. :)
Assignee | ||
Updated•6 years ago
|
Attachment #9020426 -
Flags: review?(odvarko)
Updated•6 years ago
|
Attachment #9020426 -
Flags: review?(odvarko)
Pushed by jodvarko@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f164032d6542 Provide context-fill in the network request list to ensure icons are always visible r=Honza
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f164032d6542
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in
before you can comment on or make changes to this bug.
Description
•