Closed
Bug 1501581
Opened 6 years ago
Closed 6 years ago
Add space before <label> in legacy-extensions-description
Categories
(Toolkit :: Add-ons Manager, enhancement)
Toolkit
Add-ons Manager
Tracking
()
RESOLVED
FIXED
mozilla65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: flod, Assigned: flod)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
text/x-phabricator-request
|
Details |
I think we ended up removing one space too many
The string currently looks like this
legacy-extensions-description =
These extensions do not meet current { -brand-short-name } standards so they have been deactivated.<label data-l10n-name="legacy-learn-more">Learn about the changes to add-ons</label>
Notice the lack of space before the <label> element.
This used to be
<label id="legacy-extensions-heading" value="&legacyExtensions.title;"/>
<description>
&legacyExtensions.description;
<label class="text-link plain" id="legacy-learnmore">&legacyExtensions.learnMore;</label>
</description>
So the new line was collapsed into a white space.
Assignee | ||
Comment 1•6 years ago
|
||
Side thoughts:
* The diff is going to be larger because there are a ton of trailing whitespaces in the FTL
* The Python file is using Windows line ending (I didn't touch that)
@Colin
You should double check your text editor settings, to remove trailing whitespaces and use Unix line endings.
Assignee | ||
Comment 2•6 years ago
|
||
Pushed by francesco.lodolo@mozillaitalia.org:
https://hg.mozilla.org/integration/autoland/rev/a0509a9b9a06
r=Gijs,Pike
Comment 4•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Comment 5•6 years ago
|
||
It was just the legacy extensions description?
Comment 6•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Attachment #9019911 -
Attachment is obsolete: true
Updated•6 years ago
|
Attachment #9019911 -
Attachment is obsolete: false
Updated•6 years ago
|
Attachment #9019911 -
Attachment is obsolete: true
You need to log in
before you can comment on or make changes to this bug.
Description
•