Closed Bug 1501658 Opened 6 years ago Closed 6 years ago

Add ability to search after a value in the new about:config

Categories

(Toolkit :: Preferences, enhancement, P3)

Product:
Toolkit
Component:
Preferences
Type:
enhancement

Tracking

()

Status:
RESOLVED WORKSFORME
Tracking Flags:
Tracking Status
firefox65 --- affected

People

(Reporter: Matthias, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 obsolete file)

At the moment, if you're searching for "foo" in about:config you do not only get prefs where "foo" is part of the name, but values which include "foo", too
Resetting priority to '--' so Neil can review as triage owner.
Priority: P3 → --
Paolo is the right person for this.
Flags: needinfo?(paolo.mozmail)
Yes, this is part of a number of bugs blocking bug 1493439, which is a mentored project about rewriting about:config using web technologies. We "borrowed" this Bugzilla component because the project is limited to three months and is related to existing code, even though the new code is separate and lives in the source folder of Firefox rather than Toolkit. We file all new bugs as P3 so they don't get in the way of Neil's regular triage queues. In our separate process, we just recently defined what our Minimum Viable Product looks like, so I'll update the priority to P2 on those bugs specifically, and downgrade some others to P5.
Flags: needinfo?(paolo.mozmail)
Priority: -- → P2
Priority: P2 → P3

In the new "about:config" page this can be achieved with the find-in-page functionality. Actual filtering based on anything else than the preference name would in fact make the code in bug 1501410 more complicated.

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WORKSFORME

I'd vote for reopen.

I just run into this issue and it's not intuitive to first click "show all" and then use find-in-page for some values. With the old ui I got all search results in order which was very handy to compare them.

I agree, this is really non-obvious. Paolo, care to reconsider?

My use case today was wanting to search the profiler URL in devtools.performance.recording.ui-base-url. I tried to find the preference by searching for profiler.firefox.com. When no results showed up, I definitely considered this a bug in about:config.

Alternatively, if this is really wontfix,I think it would be a good idea to change the placeholder string in the search field from "Search" to "Search preference name" to indicate that this is the intended behavior.

Flags: needinfo?(paolo.mozmail)

I think "Search preference name" is a good idea, that would also be consistent with the photon style guide
(https://design.firefox.com/photon/components/input-fields.html, last item)

Yeah, good point about changing the placeholder to "Search preference name" to both indicate that the new behavior is by design and align to the Photon style guide. Since this just aligns the text to the style guide, a patch to fix it can probably be reviewed expeditely.

Flags: needinfo?(paolo.mozmail)
Depends on: 1579115

Comment on attachment 9090136 [details]
Bug 1501658 - Adopting about:config search text to convey that you can not search values. r=paolo

Revision D44520 was moved to bug 1579115. Setting attachment 9090136 [details] to obsolete.

Attachment #9090136 - Attachment is obsolete: true

So what is the conclusion? this bug still exists in version 76

Flags: needinfo?(jaws)

This bug is closed. The decision was to keep the search limited to the preference name only.

Flags: needinfo?(jaws)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: