Closed
Bug 1501698
Opened 6 years ago
Closed 6 years ago
Remove devtools/server/actors/highlighters/flexbox.js::renderAlignItemLine()
Categories
(DevTools :: Inspector, enhancement, P2)
DevTools
Inspector
Tracking
(firefox67 fixed)
RESOLVED
FIXED
Firefox 67
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: miker, Assigned: miker)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
devtools/server/actors/highlighters/flexbox.js::renderAlignItemLine() is no longer used so we should remove it if there are no objections.
Comment 2•6 years ago
|
||
We should actually keep this and work on enabling a mode to show alignment. The stretch goal beyond M1 and M2 is to show alignment.
Flags: needinfo?(gl)
Comment 3•6 years ago
|
||
Could we simply use the fact that this code will forever live in mercurial history anyway, and get rid of it now, for the sake of making things clear?
Reasons to get rid of it:
- it's more code in the file, making it harder to read,
- it's more code to parse, load, run, making it slower,
- it's more code to maintain, which means Mike will need to make it support scroll, zoom, css transforms like the rest
All of this knowing that it's not used at all right now.
So I would strongly advise to just delete it, and recover it from mercurial later when we do start looking at alignment.
Knowing our goals for Q4, it doesn't look to me like we'll start on alignment any time soon.
Assignee | ||
Comment 4•6 years ago
|
||
Comment 5•6 years ago
|
||
I think that is reasonable. I would prefer to see this removed closer to the end of 65 so we allow the possibility of getting flexbox alignment in for 65.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → mratcliffe
Status: NEW → ASSIGNED
Pushed by mratcliffe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5b788d022b91
Remove devtools/server/actors/highlighters/flexbox.js::renderAlignItemLine() r=pbro
Comment 7•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
Comment 8•6 years ago
|
||
bugherder |
You need to log in
before you can comment on or make changes to this bug.
Description
•