Closed
Bug 1502115
Opened 6 years ago
Closed 6 years ago
Add thread annotation to API signature
Categories
(GeckoView :: General, enhancement, P2)
GeckoView
General
Tracking
(firefox65 affected)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | affected |
People
(Reporter: agi, Assigned: agi)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-github-pull-request
|
Details |
After the work in Bug 1458668 lands, we should add support for thread annotations to make sure we track that in the api.
We could simply add @UiThread, @AnyThread, and any other relevant annotation to the API in api.txt, e.g.
```
@UiThread public void onlyCallOnUiThread();
```
and then make sure that the apilint.py script picks these annotations and errors out if they change between revisions, similar to what it already does for arguments.
|
Assignee | |
Updated•6 years ago
|
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → agi
|
|
Assignee | |
Comment 1•6 years ago
|
||
This is on top of Bug 1458668 which still is waiting for review. I'll move the repo to a mozilla-* org when it's ready to be published.
|
||
Updated•6 years ago
|
Priority: -- → P2
|
|
Assignee | |
Comment 2•6 years ago
|
||
This landed as part of Bug 1458668!
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Product: Firefox for Android → GeckoView
You need to log in
before you can comment on or make changes to this bug.
Description
•