Closed
Bug 1502118
Opened 6 years ago
Closed 6 years ago
Audit and assert thread assumptions
Categories
(GeckoView :: General, enhancement, P2)
GeckoView
General
Tracking
(firefox65 wontfix, firefox66 fixed)
RESOLVED
FIXED
mozilla66
People
(Reporter: agi, Assigned: agi)
References
Details
Attachments
(11 files)
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details |
This bug is about adding thread assumption asserts like `ThreadUtils.assertOnUiThread` to every GeckoView API that assumes to be called in a specific thread (See also parent Bug 1500456).
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
Depends on D10237
Assignee | ||
Comment 3•6 years ago
|
||
Depends on D10238
Assignee | ||
Comment 4•6 years ago
|
||
This patch adds @AnyThread to any API that can be explicitely called from any
thread.
Depends on D10239
Assignee | ||
Comment 5•6 years ago
|
||
Depends on D10240
Assignee | ||
Comment 6•6 years ago
|
||
Depends on D10241
Assignee | ||
Comment 7•6 years ago
|
||
Depends on D10242
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → agi
Assignee | ||
Comment 8•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Keywords: leave-open
Pushed by asferro@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/93c80c846adb
Add @UiThread to methods that call assertOnUiThread. r=snorp.
https://hg.mozilla.org/integration/autoland/rev/c3437e254961
Add assertOnUiThread calls to GeckoDisplay. r=snorp,droeh.
https://hg.mozilla.org/integration/autoland/rev/f38363e53ca4
Fix threading documentation on GeckoResult. r=snorp.
https://hg.mozilla.org/integration/autoland/rev/aed3a7740a86
Add @AnyThread to APIs that can be used from any thread. r=snorp.
https://hg.mozilla.org/integration/autoland/rev/c26e3232d3a3
Add @UiThread to GeckoSession.TextInputDelegate. r=snorp.
https://hg.mozilla.org/integration/autoland/rev/6434abf7d806
Call assertOnUiThread in GeckoView. r=snorp.
https://hg.mozilla.org/integration/autoland/rev/1b95e3c16503
Call assertOnUiThread in SessionAccessibility. r=eeejay.
Comment 10•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/93c80c846adb
https://hg.mozilla.org/mozilla-central/rev/c3437e254961
https://hg.mozilla.org/mozilla-central/rev/f38363e53ca4
https://hg.mozilla.org/mozilla-central/rev/aed3a7740a86
https://hg.mozilla.org/mozilla-central/rev/c26e3232d3a3
https://hg.mozilla.org/mozilla-central/rev/6434abf7d806
https://hg.mozilla.org/mozilla-central/rev/1b95e3c16503
Updated•6 years ago
|
Priority: -- → P2
Assignee | ||
Comment 11•6 years ago
|
||
Assignee | ||
Comment 12•6 years ago
|
||
Depends on D13880
Assignee | ||
Comment 13•6 years ago
|
||
This allows mocking for embedders.
Depends on D13881
Assignee | ||
Comment 14•6 years ago
|
||
This makes it so that apilints lints with "GV" codes are enforced and will fail
the build.
Depends on D13882
Assignee | ||
Comment 15•6 years ago
|
||
This last stack of patches will conclude the work for this bug, yay!
Try here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9f32d4e0389231fa2a07a9c4b7db490680d516b2
Keywords: leave-open
Updated•6 years ago
|
Attachment #9029737 -
Attachment description: Bug 1502118 - Add @UiThread to all Delegate interfaces. r?snorp!,esawin! → Bug 1502118 - Add @UiThread to all Delegate interfaces. r=snorp!,esawin!
Updated•6 years ago
|
Attachment #9029738 -
Attachment description: Bug 1502118 - Add threading annotations to remaining APIs. r?snorp! → Bug 1502118 - Add threading annotations to remaining APIs. r=snorp!
Updated•6 years ago
|
Attachment #9029739 -
Attachment description: Bug 1502118 - Make FinderResult non-final for testing. r?snorp!,esawin! → Bug 1502118 - Make FinderResult non-final for testing. r=snorp!,esawin!
Updated•6 years ago
|
Attachment #9029740 -
Attachment description: Bug 1502118 - Enforce GV lints with apilint. r?snorp! → Bug 1502118 - Enforce GV lints with apilint. r=snorp!
Assignee | ||
Comment 16•6 years ago
|
||
Assignee | ||
Comment 17•6 years ago
|
||
New try with mochitest fix: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b2538689ca0e9495afe02e014f5b2e5528763892
Comment 18•6 years ago
|
||
Pushed by asferro@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/95951162d775
Add @UiThread to all Delegate interfaces. r=snorp,esawin
https://hg.mozilla.org/integration/autoland/rev/0d938252d0ed
Add threading annotations to remaining APIs. r=snorp
https://hg.mozilla.org/integration/autoland/rev/4cd3b9cf8159
Make FinderResult non-final for testing. r=snorp,esawin
https://hg.mozilla.org/integration/autoland/rev/42f4f1c36ef6
Enforce GV lints with apilint. r=snorp
Comment 19•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/95951162d775
https://hg.mozilla.org/mozilla-central/rev/0d938252d0ed
https://hg.mozilla.org/mozilla-central/rev/4cd3b9cf8159
https://hg.mozilla.org/mozilla-central/rev/42f4f1c36ef6
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
Updated•6 years ago
|
Updated•6 years ago
|
Product: Firefox for Android → GeckoView
Updated•6 years ago
|
Target Milestone: Firefox 66 → mozilla66
You need to log in
before you can comment on or make changes to this bug.
Description
•