Closed
Bug 1502266
Opened 6 years ago
Closed 6 years ago
Activity Stream falsely assumes @mozilla.org/updates/update-checker;1 is always present
Categories
(Firefox :: New Tab Page, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: kmag, Assigned: andreio)
References
Details
Attachments
(1 file)
(deleted),
text/x-github-pull-request
|
Details |
When running tests in builds with the update checker disabled, all browser tests now fail with:
A promise chain failed to handle a rejection: Cc['@mozilla.org/updates/update-checker;1'] is undefined; can't access its "createInstance" property - stack: CheckBrowserNeedsUpdate@resource://activity-stream/lib/ASRouterTargeting.jsm:66:9
Browser code can't rely on the update check service always being present, since there are compile-time options to disable it.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → andrei.br92
Comment 1•6 years ago
|
||
Updated•6 years ago
|
Iteration: --- → 65.1 (Nov 2)
Priority: -- → P1
Comment 2•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/db2f232e9cf65384df7f2c97aafcfffbcd531106
Fix Bug 1502266 - Verify that Update Checker is available before creating an instance (#4532)
Updated•6 years ago
|
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Comment 3•6 years ago
|
||
status-firefox65:
--- → fixed
Target Milestone: --- → Firefox 65
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•