The initialization sequence is complex for JSScripts and hard to reason about. This bug aims to clean-up that code.

Depends on D9944

This reorganizes the JSScript constructor sequence into the following layers and responsibilities: JSScript(...) The actual C++ constructor putting script in GC-safe state. JSScript::New(...) Performs allocation within GC. JSScript::Create(...) Common initialization for all script initialization pathways. This is more in-line with how other GC-things are created. The bitfields saved from compile options are now done at the JSScript::Create level. Depends on D9945

JSScript::partiallyInit -> JSScript::createPrivateScriptData JSScript::createScriptData -> JSScript::createSharedScriptData Depends on D9946

Depends on D9947

Pushed by tcampbell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6ae3b85ff64c Use sourceStart/sourceEnd name within JSScript r=jandem https://hg.mozilla.org/integration/autoland/rev/8ef875ecc917 Cleanup JSScript nits r=jandem https://hg.mozilla.org/integration/autoland/rev/170515f4f874 Cleanup JSScript constructor calls r=jandem https://hg.mozilla.org/integration/autoland/rev/63cb6b558afe Rename JSScript partiallyInit and friends r=jandem https://hg.mozilla.org/integration/autoland/rev/c25dd8708e93 Cleanup JSScript::initFunctionPrototype r=jandem

https://hg.mozilla.org/mozilla-central/rev/6ae3b85ff64c https://hg.mozilla.org/mozilla-central/rev/8ef875ecc917 https://hg.mozilla.org/mozilla-central/rev/170515f4f874 https://hg.mozilla.org/mozilla-central/rev/63cb6b558afe https://hg.mozilla.org/mozilla-central/rev/c25dd8708e93