Closed
Bug 1502988
Opened 6 years ago
Closed 6 years ago
Reimplementing treecol-image after treecol is converted into custom element.
Categories
(Thunderbird :: General, defect)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 65.0
People
(Reporter: arshad, Assigned: arshad)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
mkmelin
:
review+
Paenglab
:
feedback+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → arshdkhn1
Status: NEW → ASSIGNED
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 1•6 years ago
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9021141 [details] [diff] [review] treecolimage_WIP.patch Review of attachment 9021141 [details] [diff] [review]: ----------------------------------------------------------------- ::: mail/base/content/mailWidgets.js @@ +153,5 @@ > return this.getAttribute("label"); > } > } > > +class MozTreecolImage extends MozTreecolBase { I don't expect MozTreecolBase or MozTreecol will be directly accessible on the window, but I think you'll be able to do `customElement.get("treecol")` to get a reference to the class. See https://bugzilla.mozilla.org/show_bug.cgi?id=1499423#c25
Assignee | ||
Comment 3•6 years ago
|
||
(In reply to Brian Grinstead [:bgrins] from comment #2) > Comment on attachment 9021141 [details] [diff] [review] > treecolimage_WIP.patch > > Review of attachment 9021141 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: mail/base/content/mailWidgets.js > @@ +153,5 @@ > > return this.getAttribute("label"); > > } > > } > > > > +class MozTreecolImage extends MozTreecolBase { > > I don't expect MozTreecolBase or MozTreecol will be directly accessible on > the window, but I think you'll be able to do `customElement.get("treecol")` > to get a reference to the class. See > https://bugzilla.mozilla.org/show_bug.cgi?id=1499423#c25 thanks for letting me know again.
Comment 5•6 years ago
|
||
Comment on attachment 9021141 [details] [diff] [review] treecolimage_WIP.patch I tried this patch. First it doesn't apply on tip. The treecol-image have no <image class="treecol-icon"> as child and so no icon is shown.
Attachment #9021141 -
Flags: feedback-
Assignee | ||
Comment 6•6 years ago
|
||
(In reply to Richard Marti (:Paenglab) from comment #5) > Comment on attachment 9021141 [details] [diff] [review] > treecolimage_WIP.patch > > I tried this patch. > > First it doesn't apply on tip. > > The treecol-image have no <image class="treecol-icon"> as child and so no > icon is shown. just about to post a new patch.. my build is goin on.
Assignee | ||
Comment 7•6 years ago
|
||
Attachment #9021141 -
Attachment is obsolete: true
Attachment #9022096 -
Flags: review?(mkmelin+mozilla)
Assignee | ||
Comment 8•6 years ago
|
||
the 30 errors in console are not due to this patch.. I ll look into that in a new bug if required.
Assignee | ||
Updated•6 years ago
|
Attachment #9022096 -
Flags: feedback?(richard.marti)
Comment 9•6 years ago
|
||
Comment on attachment 9022096 [details] [diff] [review] treecolimage.patch Review of attachment 9022096 [details] [diff] [review]: ----------------------------------------------------------------- I'll make these changes and land it. r=mkmelin ::: mail/base/content/SearchDialog.xul @@ +128,5 @@ > context="mailContext" > onkeydown="ThreadPaneKeyDown(event);" > onselect="ThreadPaneSelectionChanged();"> > <treecols id="threadCols" pickertooltiptext="&columnChooser2.tooltip;"> > + <treecol is="treecol-image" id="threadCol" persist="hidden ordinal" fixed="true" cycler="true" would prefer id first for these ::: mail/base/content/mailWidgets.js @@ +272,5 @@ > + } > + > + const src = this.getAttribute("src"); > + > + if (src != null) { and remove attr for when it's null
Attachment #9022096 -
Flags: review?(mkmelin+mozilla) → review+
Assignee | ||
Comment 10•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=22419d99937c9883c3bcfdbcd21324b4d438556c
Comment 11•6 years ago
|
||
Comment on attachment 9022096 [details] [diff] [review] treecolimage.patch Tested on Linux and Windows. The treecol-icons are where they should be.
Attachment #9022096 -
Flags: feedback?(richard.marti) → feedback+
Comment 12•6 years ago
|
||
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/8b5b4aa26193 Adding treecol-image custom element; r=mkmelin
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Target Milestone: --- → Thunderbird 65.0
You need to log in
before you can comment on or make changes to this bug.
Description
•