Comment on attachment 9021141 [details] [diff] [review] treecolimage_WIP.patch Review of attachment 9021141 [details] [diff] [review]: ----------------------------------------------------------------- ::: mail/base/content/mailWidgets.js @@ +153,5 @@ > return this.getAttribute("label"); > } > } > > +class MozTreecolImage extends MozTreecolBase { I don't expect MozTreecolBase or MozTreecol will be directly accessible on the window, but I think you'll be able to do `customElement.get("treecol")` to get a reference to the class. See https://bugzilla.mozilla.org/show_bug.cgi?id=1499423#c25

(In reply to Brian Grinstead [:bgrins] from comment #2) > Comment on attachment 9021141 [details] [diff] [review] > treecolimage_WIP.patch > > Review of attachment 9021141 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: mail/base/content/mailWidgets.js > @@ +153,5 @@ > > return this.getAttribute("label"); > > } > > } > > > > +class MozTreecolImage extends MozTreecolBase { > > I don't expect MozTreecolBase or MozTreecol will be directly accessible on > the window, but I think you'll be able to do `customElement.get("treecol")` > to get a reference to the class. See > https://bugzilla.mozilla.org/show_bug.cgi?id=1499423#c25 thanks for letting me know again.

This has become urgent since we have 217 test failures over in bug 1504076.

Comment on attachment 9021141 [details] [diff] [review] treecolimage_WIP.patch I tried this patch. First it doesn't apply on tip. The treecol-image have no <image class="treecol-icon"> as child and so no icon is shown.

(In reply to Richard Marti (:Paenglab) from comment #5) > Comment on attachment 9021141 [details] [diff] [review] > treecolimage_WIP.patch > > I tried this patch. > > First it doesn't apply on tip. > > The treecol-image have no <image class="treecol-icon"> as child and so no > icon is shown. just about to post a new patch.. my build is goin on.

the 30 errors in console are not due to this patch.. I ll look into that in a new bug if required.

Comment on attachment 9022096 [details] [diff] [review] treecolimage.patch Review of attachment 9022096 [details] [diff] [review]: ----------------------------------------------------------------- I'll make these changes and land it. r=mkmelin ::: mail/base/content/SearchDialog.xul @@ +128,5 @@ > context="mailContext" > onkeydown="ThreadPaneKeyDown(event);" > onselect="ThreadPaneSelectionChanged();"> > <treecols id="threadCols" pickertooltiptext="&columnChooser2.tooltip;"> > + <treecol is="treecol-image" id="threadCol" persist="hidden ordinal" fixed="true" cycler="true" would prefer id first for these ::: mail/base/content/mailWidgets.js @@ +272,5 @@ > + } > + > + const src = this.getAttribute("src"); > + > + if (src != null) { and remove attr for when it's null

Comment on attachment 9022096 [details] [diff] [review] treecolimage.patch Tested on Linux and Windows. The treecol-icons are where they should be.

Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/8b5b4aa26193 Adding treecol-image custom element; r=mkmelin