DRM notification displays unnecessary blank spaces before and after Learn More link
Categories
(Firefox :: Site Identity, defect, P5)
Tracking
()
Tracking | Status | |
---|---|---|
firefox68 | --- | fixed |
People
(Reporter: flod, Assigned: paarmita1998, Mentored)
Details
Attachments
(2 files)
Comment 1•6 years ago
|
||
Reporter | ||
Comment 2•6 years ago
|
||
Comment 3•6 years ago
|
||
Reporter | ||
Comment 4•6 years ago
|
||
Comment 5•6 years ago
|
||
Reporter | ||
Comment 6•6 years ago
|
||
Comment 7•6 years ago
|
||
Comment 8•6 years ago
|
||
I can work on this!
Updated•6 years ago
|
Comment 11•6 years ago
|
||
Hi Johann,
If someone is interested then please assign to them,
else I will work after 2-3 weeks on this.
These days bit busy with work.
Thanks
Comment 12•6 years ago
|
||
Ok, thanks, unassigning you for now, feel free to pick this up again later.
Assignee | ||
Comment 13•6 years ago
|
||
Hi,
I am an outreachy applicant, and would like to work on this issue as my second contribution?
Comment 14•6 years ago
|
||
Hi Paramita,
Sure, you can work on this, I think right now no one is working on this.
Submit the patch.
Johann will assign this bug to you.
Comment 15•6 years ago
|
||
Alright, feel free to give this a shot. You can trigger this by disabling "Play DRM-controlled content" in about:preferences and visiting a site with EME content, such as https://shaka-player-demo.appspot.com/demo/#asset=https://media.axprod.net/TestVectors/v7-MultiDRM-SingleKey/Manifest.mpd;lang=en-US;build=uncompiled
Then you would need to inspect the yellow notification bar with the Browser Toolbox to figure out which CSS rule is adding the extra margin.
Assignee | ||
Comment 16•6 years ago
|
||
Thanks. I will work on it. But if I need to ask anything where can I contact the mentors?
Comment 17•6 years ago
|
||
IRC channels.
For general help: #Introduction
Firefox: #fx-team
Johann is also available on IRC. his IRC name: [:johannh]
else you can post your questions here and tag person in "Need more information from <Email>" section.
Comment 18•6 years ago
|
||
Yup, thank you, Manish!
Assignee | ||
Comment 19•6 years ago
|
||
Hey,
I did the changes and made a patch. Can you please review- https://phabricator.services.mozilla.com/D21594
Assignee | ||
Comment 20•6 years ago
|
||
Comment 21•6 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:paarmita1998, could you have a look please?
Assignee | ||
Comment 22•6 years ago
|
||
The Patch created is ready to land as the changes are being accepted.
Comment 23•6 years ago
|
||
Hi Paarmita, did you see my comment in Phabricator? Can you follow-up before landing, please? :)
Assignee | ||
Comment 24•6 years ago
|
||
Hey Johann, I have checked your comment and it doesn't show the desired behavior on margin: 0px
. So it is resolved.
Comment 25•6 years ago
|
||
(In reply to Paarmita Bhargava from comment #24)
Hey Johann, I have checked your comment and it doesn't show the desired behavior on
margin: 0px
. So it is resolved.
Ok, thanks for checking that, feel free to set checkin-needed
then.
Comment 26•6 years ago
|
||
Assignee | ||
Comment 27•6 years ago
|
||
Hey Johann,
Is this issue fixed?
Reporter | ||
Comment 28•6 years ago
|
||
(In reply to Paarmita Bhargava from comment #27)
Hey Johann,
Is this issue fixed?
No. It landed on the integration branch, it's not in mozilla-central yet (and consequently not in Nightly).
Comment 29•6 years ago
|
||
bugherder |
Description
•