Closed
Bug 1503540
Opened 6 years ago
Closed 6 years ago
Reduce the amount of rendered rows in the new about:config
Categories
(Toolkit :: Preferences, defect, P1)
Toolkit
Preferences
Tracking
()
RESOLVED
FIXED
mozilla66
People
(Reporter: Matthias, Assigned: Paolo)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
To improve the overall performance (cf. 1500548)
Maybe with using a virtual list, like https://github.com/sergi/virtual-list
Assignee | ||
Comment 1•6 years ago
|
||
Thanks for filing the bug!
> Maybe with using a virtual list
As I mentioned in bug 1500548 comment 5, and repeating here just to avoid confusion to people coming across this bug, we already know that we don't want to implement or import a virtual list specifically for this page.
We can maybe wait to show results until the first query is typed, and then either just limit the number of results or, more likely, accept that we'll have a slight performance regression on resize. Again, the Firefox team will have to make an evaluation here about the perceived performance characteristics, which may be partly subjective.
Reporter | ||
Comment 2•6 years ago
|
||
I thought that using an open-source solution would do the trick, sorry.
Assignee | ||
Comment 3•6 years ago
|
||
Yes, of course being open source is a requirement if we want to import external code, but there are many other characteristics that we have to keep into account regardless of who writes the code. A simple implementation wouldn't necessarily meet our other requirements for accessibility, keyboard interaction, performance, and so on, and a more complex one is not worth the maintenance cost just for this page.
For example, even if the code you linked is relatively simple compared to others, I already see a source code comment related to triggering a reflow. This is a whole other conversation and you don't need to worry about this for the project, but there is some more context about this performance characteristic here if you're curious:
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Performance_best_practices_for_Firefox_fe_engineers#Detecting_and_avoiding_synchronous_reflow
Assignee | ||
Comment 4•6 years ago
|
||
Pushed by paolo.mozmail@amadzone.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6f69caa667c9
Don't show all values until the list is filtered. r=mak
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Priority: P5 → P1
Comment 6•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Updated•6 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•