Closed Bug 1503678 Opened 6 years ago Closed 4 years ago

Item reordering in customize mode does not respect prefers-reduced-motion

Categories

(Toolkit :: Toolbars and Toolbar Customization, defect, P3)

Product:
Toolkit
Component:
Toolbars and Toolbar Customization
Version:
63 Branch
Type:
defect
Points:
2

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla80
Iteration:
80.1 - June 29 - July 12
Tracking Flags:
Tracking Status
firefox63 --- wontfix
firefox64 --- wontfix
firefox65 --- wontfix
firefox80 --- fixed

People

(Reporter: charles.belov, Assigned: dao)

References

(Blocks 1 open bug)

Details

(Keywords: access)

Attachments

(1 file)

Bug 1503678 - Respect prefers-reduced-motion when reordering items in customize mode. r=gijs
(deleted), text/x-phabricator-request
Details
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0) Gecko/20100101 Firefox/63.0 Steps to reproduce: Steps: 1. Set Windows 10 Ease of Access option "Show animations in Windows" to off 2. Launch Firefox 63 3. In menu, choose Customize 4. Drag Bookmarks Menu from array of customizable icons to menu bar Actual results: Other icons animate while I am dragging the Bookmarks Menu icon. Expected results: Nothing else moves while I am dragging the Bookmarks Menu icon. Once I have released my drag of the Bookmarks Menu, the remaining icons display to fill the empty area without using animation to accomplish this.
User Agent:  Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0 Build ID: 20181105100136 I manage to reproduce this on Windows 10 x64 with Firefox Nightly 65.0a1 (2018-11-05) (64-bit).
Status: UNCONFIRMED → NEW
status-firefox63: --- → affected
status-firefox64: --- → affected
status-firefox65: --- → affected
Component: Untriaged → Toolbars and Toolbar Customization
Ever confirmed: true
Product: Firefox → Toolkit
Priority: -- → P3
Blocks: 1478597
Depends on: 1635095
Keywords: access
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Iteration: --- → 80.1 - June 29 - July 12
Points: --- → 2
Summary: Customize mode does not respect prefers-reduced-motion → Item reordering in customize mode does not respect prefers-reduced-motion
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d3f7f11b80ea Respect prefers-reduced-motion when reordering items in customize mode. r=Gijs

Backed out changeset d3f7f11b80ea (bug 1503678) for widget-overflow-fixed-list related failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedTaskRun=XL0B74J4R72osF5okfkVrQ.0&searchStr=windows%2C10%2Cx64%2Cdebug%2Cmochitests%2Ctest-windows10-64%2Fdebug-mochitest-browser-chrome-e10s-4%2Cm%28bc4%29&fromchange=ac98e10373215008557ccb877fa0b8d1eb981d35&tochange=35ebecc3af12e2fc726f3ccc7218d45fb459d7f5

Backout link: https://hg.mozilla.org/integration/autoland/rev/35ebecc3af12e2fc726f3ccc7218d45fb459d7f5

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=308942496&repo=autoland&lineNumber=10046

[task 2020-07-08T07:29:41.760Z] 07:29:41     INFO - TEST-START | browser/components/customizableui/test/browser_878452_drag_to_panel.js
[task 2020-07-08T07:29:41.770Z] 07:29:41     INFO - GECKO(10048) | console.error: CustomizableUI:
[task 2020-07-08T07:29:41.770Z] 07:29:41     INFO - GECKO(10048) |   Could not localize property 'cui-panel-item-to-drag-to.tooltiptext'.
[task 2020-07-08T07:29:41.771Z] 07:29:41     INFO - GECKO(10048) | [Parent 5008: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 000001E3992EE400 == 18 [pid = 5008] [id = {01f863cb-c5bc-4e6e-8eed-7f1dd7d056f0}]
[task 2020-07-08T07:29:41.771Z] 07:29:41     INFO - GECKO(10048) | [Parent 5008: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 36 (000001E38D450C10) [pid = 5008] [serial = 46] [outer = 0000000000000000]
[task 2020-07-08T07:29:41.773Z] 07:29:41     INFO - GECKO(10048) | [Parent 5008: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 37 (000001E3992E8000) [pid = 5008] [serial = 47] [outer = 000001E38D450C10]
[task 2020-07-08T07:29:41.918Z] 07:29:41     INFO - GECKO(10048) | [Child 7192: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 11 (000001CD383BC000) [pid = 7192] [serial = 26] [outer = 0000000000000000] [url = about:blank]
[task 2020-07-08T07:29:41.918Z] 07:29:41     INFO - GECKO(10048) | [Child 7192: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 10 (000001CD383B3800) [pid = 7192] [serial = 20] [outer = 0000000000000000] [url = about:blank]
[task 2020-07-08T07:29:41.918Z] 07:29:41     INFO - GECKO(10048) | [Child 7192: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 9 (000001CD383AF800) [pid = 7192] [serial = 17] [outer = 0000000000000000] [url = about:blank]
[task 2020-07-08T07:29:41.918Z] 07:29:41     INFO - GECKO(10048) | [Child 7192: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 8 (000001CD383B7C00) [pid = 7192] [serial = 23] [outer = 0000000000000000] [url = data:text/html,<html><body></body></html>]
[task 2020-07-08T07:29:41.918Z] 07:29:41     INFO - GECKO(10048) | [Child 7192: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 000001CD383B4C00 == 2 [pid = 7192] [id = {d03c6e70-53c8-48ff-8fe2-9e3fb6f37380}] [url = about:blank]
[task 2020-07-08T07:29:41.919Z] 07:29:41     INFO - GECKO(10048) | [Child 7192: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 000001CD37F4A400 == 1 [pid = 7192] [id = {91937f67-5902-4e0f-b663-88b56c3df1d9}] [url = about:blank]
[task 2020-07-08T07:29:41.919Z] 07:29:41     INFO - GECKO(10048) | [Child 7192: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 000001CD31941800 == 0 [pid = 7192] [id = {7dc85c9d-842b-4e42-a24b-dc7dad23abaa}] [url = about:blank]
[task 2020-07-08T07:29:42.384Z] 07:29:42     INFO - TEST-INFO | started process screenshot
[task 2020-07-08T07:29:42.443Z] 07:29:42     INFO - TEST-INFO | screenshot: exit 0
[task 2020-07-08T07:29:42.443Z] 07:29:42     INFO - Buffered messages logged at 07:29:41
[task 2020-07-08T07:29:42.443Z] 07:29:42     INFO - Entering test bound 
[task 2020-07-08T07:29:42.443Z] 07:29:42     INFO - Buffered messages logged at 07:29:42
[task 2020-07-08T07:29:42.443Z] 07:29:42     INFO - Actual placements: new-window-button, cui-panel-item-to-drag-to
[task 2020-07-08T07:29:42.443Z] 07:29:42     INFO - Expected placements: new-window-button, cui-panel-item-to-drag-to
[task 2020-07-08T07:29:42.443Z] 07:29:42     INFO - TEST-PASS | browser/components/customizableui/test/browser_878452_drag_to_panel.js | Area widget-overflow-fixed-list should have 2 items. - 
[task 2020-07-08T07:29:42.443Z] 07:29:42     INFO - TEST-PASS | browser/components/customizableui/test/browser_878452_drag_to_panel.js | Item 0 in widget-overflow-fixed-list should match expectations. - 
[task 2020-07-08T07:29:42.444Z] 07:29:42     INFO - TEST-PASS | browser/components/customizableui/test/browser_878452_drag_to_panel.js | Item 1 in widget-overflow-fixed-list should match expectations. - 
[task 2020-07-08T07:29:42.444Z] 07:29:42     INFO - TEST-PASS | browser/components/customizableui/test/browser_878452_drag_to_panel.js | Should no longer be in default state. - 
[task 2020-07-08T07:29:42.444Z] 07:29:42     INFO - TEST-PASS | browser/components/customizableui/test/browser_878452_drag_to_panel.js | Should be in default state again. - 
[task 2020-07-08T07:29:42.444Z] 07:29:42     INFO - Leaving test bound 
[task 2020-07-08T07:29:42.444Z] 07:29:42     INFO - Entering test bound 
[task 2020-07-08T07:29:42.444Z] 07:29:42     INFO - Actual placements: cui-panel-item-to-drag-to, bookmarks-menu-button
[task 2020-07-08T07:29:42.445Z] 07:29:42     INFO - Expected placements: cui-panel-item-to-drag-to, new-window-button
[task 2020-07-08T07:29:42.445Z] 07:29:42     INFO - TEST-PASS | browser/components/customizableui/test/browser_878452_drag_to_panel.js | Area widget-overflow-fixed-list should have 2 items. - 
[task 2020-07-08T07:29:42.445Z] 07:29:42     INFO - TEST-PASS | browser/components/customizableui/test/browser_878452_drag_to_panel.js | Item 0 in widget-overflow-fixed-list should match expectations. - 
[task 2020-07-08T07:29:42.445Z] 07:29:42     INFO - Buffered messages finished
[task 2020-07-08T07:29:42.445Z] 07:29:42     INFO - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_878452_drag_to_panel.js | Item 1 in widget-overflow-fixed-list should match expectations. - Got bookmarks-menu-button, expected new-window-button
[task 2020-07-08T07:29:42.445Z] 07:29:42     INFO - Stack trace:
[task 2020-07-08T07:29:42.445Z] 07:29:42     INFO - chrome://mochikit/content/browser-test.js:test_is:1327
[task 2020-07-08T07:29:42.445Z] 07:29:42     INFO - chrome://mochitests/content/browser/browser/components/customizableui/test/head.js:placementArraysEqual:157
[task 2020-07-08T07:29:42.445Z] 07:29:42     INFO - chrome://mochitests/content/browser/browser/components/customizableui/test/head.js:assertAreaPlacements:143
[task 2020-07-08T07:29:42.445Z] 07:29:42     INFO - chrome://mochitests/content/browser/browser/components/customizableui/test/browser_878452_drag_to_panel.js:null:49
[task 2020-07-08T07:29:42.445Z] 07:29:42     INFO - TEST-PASS | browser/components/customizableui/test/browser_878452_drag_to_panel.js | Should no longer be in default state. - 
[task 2020-07-08T07:29:42.495Z] 07:29:42     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-07-08T07:29:42.495Z] 07:29:42     INFO - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_878452_drag_to_panel.js | Should be in default state again. - 
[task 2020-07-08T07:29:42.495Z] 07:29:42     INFO - Stack trace:
[task 2020-07-08T07:29:42.495Z] 07:29:42     INFO - chrome://mochikit/content/browser-test.js:test_ok:1299
[task 2020-07-08T07:29:42.495Z] 07:29:42     INFO - chrome://mochitests/content/browser/browser/components/customizableui/test/browser_878452_drag_to_panel.js:null:57
[task 2020-07-08T07:29:42.495Z] 07:29:42     INFO - Leaving test bound 
[task 2020-07-08T07:29:42.495Z] 07:29:42     INFO - Entering test bound 
[task 2020-07-08T07:29:42.495Z] 07:29:42     INFO - Actual placements: 
[task 2020-07-08T07:29:42.496Z] 07:29:42     INFO - Expected placements: 
[task 2020-07-08T07:29:42.496Z] 07:29:42     INFO - TEST-PASS | browser/components/customizableui/test/browser_878452_drag_to_panel.js | Area widget-overflow-fixed-list should have 0 items. - 
[task 2020-07-08T07:29:42.575Z] 07:29:42     INFO - Actual placements: fullscreen-button
[task 2020-07-08T07:29:42.575Z] 07:29:42     INFO - Expected placements: new-window-button
[task 2020-07-08T07:29:42.577Z] 07:29:42     INFO - TEST-PASS | browser/components/customizableui/test/browser_878452_drag_to_panel.js | Area widget-overflow-fixed-list should have 1 items. - 
[task 2020-07-08T07:29:42.577Z] 07:29:42     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-07-08T07:29:42.577Z] 07:29:42     INFO - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_878452_drag_to_panel.js | Item 0 in widget-overflow-fixed-list should match expectations. - Got fullscreen-button, expected new-window-button
[task 2020-07-08T07:29:42.577Z] 07:29:42     INFO - Stack trace:
[task 2020-07-08T07:29:42.577Z] 07:29:42     INFO - chrome://mochikit/content/browser-test.js:test_is:1327
[task 2020-07-08T07:29:42.577Z] 07:29:42     INFO - chrome://mochitests/content/browser/browser/components/customizableui/test/head.js:placementArraysEqual:157
[task 2020-07-08T07:29:42.577Z] 07:29:42     INFO - chrome://mochitests/content/browser/browser/components/customizableui/test/head.js:assertAreaPlacements:143
[task 2020-07-08T07:29:42.577Z] 07:29:42     INFO - chrome://mochitests/content/browser/browser/components/customizableui/test/browser_878452_drag_to_panel.js:null:74
[task 2020-07-08T07:29:42.577Z] 07:29:42     INFO - TEST-PASS | browser/components/customizableui/test/browser_878452_drag_to_panel.js | Should no longer be in default state. - 
[task 2020-07-08T07:29:42.699Z] 07:29:42     INFO - Actual placements: fullscreen-button
[task 2020-07-08T07:29:42.699Z] 07:29:42     INFO - Expected placements: 
[task 2020-07-08T07:29:42.699Z] 07:29:42     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-07-08T07:29:42.699Z] 07:29:42     INFO - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_878452_drag_to_panel.js | Area widget-overflow-fixed-list should have 0 items. - Got 1, expected 0
[task 2020-07-08T07:29:42.699Z] 07:29:42     INFO - Stack trace:
[task 2020-07-08T07:29:42.699Z] 07:29:42     INFO - chrome://mochikit/content/browser-test.js:test_is:1327
[task 2020-07-08T07:29:42.699Z] 07:29:42     INFO - chrome://mochitests/content/browser/browser/components/customizableui/test/head.js:placementArraysEqual:149
[task 2020-07-08T07:29:42.699Z] 07:29:42     INFO - chrome://mochitests/content/browser/browser/components/customizableui/test/head.js:assertAreaPlacements:143
[task 2020-07-08T07:29:42.700Z] 07:29:42     INFO - chrome://mochitests/content/browser/browser/components/customizableui/test/browser_878452_drag_to_panel.js:null:81
[task 2020-07-08T07:29:42.700Z] 07:29:42     INFO - Leaving test bound 
[task 2020-07-08T07:29:43.084Z] 07:29:43     INFO - GECKO(10048) | [Parent 5008, Main Thread] WARNING: '!inner', file /builds/worker/checkouts/gecko/dom/ipc/JSWindowActorProtocol.cpp, line 172
[task 2020-07-08T07:29:43.084Z] 07:29:43     INFO - GECKO(10048) | [Parent 5008, Main Thread] WARNING: '!inner', file /builds/worker/checkouts/gecko/dom/ipc/JSWindowActorProtocol.cpp, line 172
[task 2020-07-08T07:29:43.307Z] 07:29:43     INFO - GECKO(10048) | MEMORY STAT | vsize 2104464MB | vsizeMaxContiguous 65312425MB | residentFast 443MB | heapAllocated 158MB
[task 2020-07-08T07:29:43.307Z] 07:29:43     INFO - TEST-OK | browser/components/customizableui/test/browser_878452_drag_to_panel.js | took 1545ms
Flags: needinfo?(dao+bmo)
Flags: needinfo?(dao+bmo)
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d52b5b3ffd17 Respect prefers-reduced-motion when reordering items in customize mode. r=Gijs

https://hg.mozilla.org/mozilla-central/rev/d52b5b3ffd17

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox80: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: