Closed
Bug 1503882
Opened 6 years ago
Closed 5 years ago
Use onFront to register toolbox listeners on inspector fronts
Categories
(DevTools :: Inspector, enhancement, P2)
DevTools
Inspector
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1568157
People
(Reporter: yulia, Assigned: yulia)
References
Details
(Whiteboard: dt-fission)
The toolbox currently holds a reference to the inspector, where it should only register callback on the creation of an inspectorFront instance. (see https://searchfox.org/mozilla-central/rev/4436573fa3d5c4311822090e188504c10c916c6f/devtools/client/framework/toolbox.js#3274-3283)
For example:
```
target.onFront("inspector", front => {
front.selection.on("new-node-front", this._onNewSelectedNodeFront);
if (this.highlighterUtils.isRemoteHighlightable()) {
front.walker.on("highlighter-ready", this._highlighterReady);
front.walker.on("highlighter-hide", this._highlighterHidden);
}
}
```
|
Assignee | |
Updated•6 years ago
|
Severity: normal → enhancement
|
||
Comment 1•5 years ago
|
||
Yulia, Could this bug be a duplicate of bug 1500142?
If not, given the clarification I made via the new bugs under bug 1500142, what else should we do?
Flags: needinfo?(ystartsev)
|
|
Assignee | |
Comment 2•5 years ago
|
||
The description here is a bit confusing. I think this could be a child of bug 1500142. I updated the naming of this to be clearer about what the goal is here.
Blocks: 1500142
Flags: needinfo?(ystartsev)
Summary: Remove inspector-related front specifics out of toolbox class → Use onFront to register toolbox listeners on inspector fronts
|
||
Comment 3•5 years ago
|
||
I used this in Bug 1568157
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•