Closed
Bug 1504016
Opened 6 years ago
Closed 6 years ago
aarch64-windows builds broken due to webp's NEON code
Categories
(Core :: Graphics: ImageLib, defect)
Core
Graphics: ImageLib
Tracking
()
RESOLVED
FIXED
mozilla65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: away, Assigned: away)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
webp's NEON code causes build bustage on aarch64-windows, at least due to:
* arm_neon.h versus arm64_neon.h
* using inline asm (WEBP_USE_INTRINSICS not picked up?)
I don't want to context-switch away from the thing I was actually working on when I refreshed my tree, so I'd like to just disable webp's NEON for now on WINNT, and fix it up under a followup bug.
Assignee: nobody → dmajor
Attachment #9021943 -
Flags: review?(nfroyd)
|
||
Comment 2•6 years ago
|
||
Mea culpa. I didn't even know we had an aarch64-windows build. There isn't one in try fuzzy, so I guess this is a new target?
|
||
Updated•6 years ago
|
Attachment #9021943 -
Flags: review?(nfroyd) → review+
|
|
||
Comment 3•6 years ago
|
||
(In reply to Andrew Osmond [:aosmond] from comment #2)
> Mea culpa. I didn't even know we had an aarch64-windows build. There isn't
> one in try fuzzy, so I guess this is a new target?
Don't worry about it! It is a new target and it's not (yet) in automation, so breaking it is not your problem at the moment.
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b8d0312c16dc
Disable webp's NEON on aarch64-windows due to bustage. r=froydnj
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•