Completely broken extension data storage -- due to Firefox creating directory in profile/storage/default
Categories
(Core :: Storage: IndexedDB, defect, P2)
Tracking
()
People
(Reporter: spam04321, Assigned: tt)
References
(Blocks 2 open bugs)
Details
Attachments
(6 files, 5 obsolete files)
Comment 1•6 years ago
|
||
Comment 2•6 years ago
|
||
Comment 3•6 years ago
|
||
Comment 4•6 years ago
|
||
Updated•6 years ago
|
Reporter | ||
Comment 6•6 years ago
|
||
Updated•6 years ago
|
Comment 7•6 years ago
|
||
Comment 8•6 years ago
|
||
Assignee | ||
Comment 9•6 years ago
|
||
Assignee | ||
Comment 10•6 years ago
|
||
Assignee | ||
Comment 11•6 years ago
|
||
Reporter | ||
Comment 12•6 years ago
|
||
Reporter | ||
Comment 13•6 years ago
|
||
Assignee | ||
Comment 14•6 years ago
|
||
Reporter | ||
Comment 15•6 years ago
|
||
Assignee | ||
Comment 16•6 years ago
|
||
Assignee | ||
Comment 17•6 years ago
|
||
Assignee | ||
Comment 18•6 years ago
|
||
Updated•6 years ago
|
Updated•6 years ago
|
Comment 19•6 years ago
|
||
Reporter | ||
Comment 20•6 years ago
|
||
Comment 21•6 years ago
|
||
Reporter | ||
Comment 22•6 years ago
|
||
Comment 23•6 years ago
|
||
Assignee | ||
Comment 24•6 years ago
|
||
Assignee | ||
Comment 25•6 years ago
|
||
Comment 26•6 years ago
|
||
Comment 27•6 years ago
|
||
Comment 28•6 years ago
|
||
Assignee | ||
Comment 29•6 years ago
|
||
Comment 30•6 years ago
|
||
Assignee | ||
Comment 31•6 years ago
|
||
Reporter | ||
Comment 32•6 years ago
|
||
Assignee | ||
Comment 33•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 34•6 years ago
|
||
Assignee | ||
Comment 35•6 years ago
|
||
Assignee | ||
Comment 36•6 years ago
|
||
Assignee | ||
Comment 37•6 years ago
|
||
Assignee | ||
Comment 38•6 years ago
|
||
Assignee | ||
Comment 39•6 years ago
|
||
Assignee | ||
Comment 40•6 years ago
|
||
Assignee | ||
Comment 41•6 years ago
|
||
Assignee | ||
Comment 42•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 43•6 years ago
|
||
Andrew, would you mind checking the change I made from addressing your comment for P1? Especially, line 7870 and line 15792. Thanks!
interdiff: https://phabricator.services.mozilla.com/D16446?vs=51249&id=52586&whitespace=ignore-most#toc
Updated•6 years ago
|
Assignee | ||
Comment 45•6 years ago
|
||
Depends on D16820
Assignee | ||
Comment 46•6 years ago
|
||
Andrew, I rebase patches and change a few of them. Would you mind taking one more look? Thanks!
Since the bug for supporting async/await on IDB tests was fixed, I change the patches for test. If you don't think it's necessary, I could change them back to generator function.
Here is the short-cut for the interdiff patches.
P2 changing style to async/await
https://phabricator.services.mozilla.com/D16447?vs=52543&id=53647&whitespace=ignore-most#toc
P4 changing style to async/await
https://phabricator.services.mozilla.com/D16820?vs=52545&id=53650&whitespace=ignore-most#toc
Also for P3, I update the telemetry to external error both IDB_GetEntry and IDB_GetBaseFilename since P3 removes unexpected directory when finding it at first.
https://phabricator.services.mozilla.com/D16448?vs=52544&id=53648&whitespace=ignore-most#toc
Assignee | ||
Comment 47•6 years ago
|
||
In the team meeting, we decided to land patches in 67 because it might be problematic when backing out.
Updated•6 years ago
|
Assignee | ||
Comment 48•6 years ago
|
||
Hi chutten, we want to check one more external error for initialization. The implementation is P5. Would you mind reviewing it? Thanks!
Assignee | ||
Comment 49•6 years ago
|
||
Comment 50•6 years ago
|
||
Comment 51•6 years ago
|
||
Assignee | ||
Comment 52•6 years ago
|
||
Last 7 days, we got 2.42M samples for failing to get IDB entries [1]. The number should drop down after applying P3.
Comment 53•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/beb12bda21cb
https://hg.mozilla.org/mozilla-central/rev/a1dc7e61497c
https://hg.mozilla.org/mozilla-central/rev/028a1ddd6052
https://hg.mozilla.org/mozilla-central/rev/2cfab2d01692
https://hg.mozilla.org/mozilla-central/rev/7418083f19a8
Updated•6 years ago
|
Comment 54•6 years ago
|
||
Guessing this is not an uplift candidate. Feel free to reset 66 status and request approval if I got this wrong.
Description
•