In a few xpcshell test cases, we use eval(), new Function. Usage of eval() or new Function() will trigger Assertion in nsScriptSecurityManager. Hence we are adding prefs to these test files for toggling the assertion. Prefs are added to 64 xpcshell test files, 1. devtools/client/debugger/test/mochitest/head.js 2. devtools/client/shared/test/browser_dbg_listworkers.js 3. devtools/client/storage/test/browser_storage_dynamic_updates_cookies.js 4. devtools/server/tests/unit/test_framebindings-01.js 5. devtools/server/tests/unit/test_framebindings-02.js 6. devtools/server/tests/unit/test_framebindings-03.js 7. devtools/server/tests/unit/test_framebindings-04.js 8. devtools/server/tests/unit/test_framebindings-05.js 9. devtools/server/tests/unit/test_framebindings-06.js 10. devtools/server/tests/unit/test_framebindings-07.js 11. devtools/server/tests/unit/test_longstringgrips-01.js 12. devtools/server/tests/unit/test_longstringgrips-02.js 13. devtools/server/tests/unit/test_objectgrips-04.js 14. devtools/server/tests/unit/test_objectgrips-05.js 15. devtools/server/tests/unit/test_objectgrips-06.js 16. devtools/server/tests/unit/test_objectgrips-07.js 17. devtools/server/tests/unit/test_objectgrips-08.js 18. devtools/server/tests/unit/test_objectgrips-09.js 19. devtools/server/tests/unit/test_objectgrips-10.js 20. devtools/server/tests/unit/test_objectgrips-11.js 21. devtools/server/tests/unit/test_objectgrips-12.js 22. devtools/server/tests/unit/test_objectgrips-16.js 23. devtools/server/tests/unit/test_objectgrips-17.js 24. devtools/server/tests/unit/test_objectgrips-18.js 25. devtools/server/tests/unit/test_objectgrips-19.js 26. devtools/server/tests/unit/test_objectgrips-20.js 27. devtools/server/tests/unit/test_objectgrips-21.js 28. devtools/server/tests/unit/test_objectgrips-22.js 29. devtools/server/tests/unit/test_objectgrips-array-like-object.js 30. devtools/server/tests/unit/test_objectgrips-fn-apply-01.js 31. devtools/server/tests/unit/test_objectgrips-fn-apply-02.js 32. devtools/server/tests/unit/test_objectgrips-fn-apply-03.js 33. devtools/server/tests/unit/test_objectgrips-property-value-01.js 34. devtools/server/tests/unit/test_objectgrips-property-value-02.js 35. devtools/server/tests/unit/test_pause_exceptions-01.js 36. devtools/server/tests/unit/test_pause_exceptions-02.js 37. devtools/server/tests/unit/test_stepping-05.js 38. dom/plugins/test/mochitest/test_hangui.xul 39. intl/uconv/tests/unit/test_bug340714.js 40. js/ductwork/debugger/tests/test_nativewrappers.js 41. js/xpconnect/tests/chrome/test_bug596580.xul 42. js/xpconnect/tests/chrome/test_bug732665.xul 43. js/xpconnect/tests/chrome/test_xrayToJS.xul 44. js/xpconnect/tests/unit/test_ComponentEnvironment.js 45. js/xpconnect/tests/unit/test_FrameScriptEnvironment.js 46. js/xpconnect/tests/unit/test_SubscriptLoaderEnvironment.js 47. js/xpconnect/tests/unit/test_SubscriptLoaderJSMEnvironment.js 48. js/xpconnect/tests/unit/test_SubscriptLoaderSandboxEnvironment.js 49. js/xpconnect/tests/unit/test_bug1244222.js 50. js/xpconnect/tests/unit/test_classesByID_instanceof.js 51. js/xpconnect/tests/unit/test_onGarbageCollection-01.js 52. js/xpconnect/tests/unit/test_onGarbageCollection-02.js 53. js/xpconnect/tests/unit/test_onGarbageCollection-03.js 54. js/xpconnect/tests/unit/test_onGarbageCollection-04.js 55. js/xpconnect/tests/unit/test_onGarbageCollection-05.js 56. js/xpconnect/tests/unit/test_xrayed_iterator.js 57. netwerk/test/unit/test_chunked_responses.js 58. netwerk/test/unit/test_content_length_underrun.js 59. services/sync/tests/unit/test_utils_deepEquals.js 60. toolkit/components/contentprefs/tests/unit_cps2/test_observers.js 61. toolkit/components/ctypes/tests/unit/test_jsctypes.js 62. toolkit/components/feeds/test/test_xml.js 63. toolkit/modules/tests/xpcshell/test_GMPInstallManager.js 64. toolkit/modules/tests/xpcshell/test_Log.js

Comment on attachment 9022508 [details] Bug 1504605 - Add Prefs to xpcshell test files for allowing usage of eval Please kindly review the patch and let me know if changes are needed. Corresponding TRY push for this patch, https://treeherder.mozilla.org/#/jobs?repo=try&revision=31addfd9409d05c1c336772baa336d2dc878858f

Comment on attachment 9022508 [details] Bug 1504605 - Add Prefs to xpcshell test files for allowing usage of eval that looks good to me - thanks!

Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ffb244265196 Add Prefs to xpcshell test files for allowing usage of eval. r=ckerschb