Closed Bug 1505225 Opened 6 years ago Closed 6 years ago

Individual transform properties' animations don't create stacking context in delay phase

Categories

(Core :: CSS Transitions and Animations, defect, P3)

Product:
Core
Component:
CSS Transitions and Animations
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: hiro, Assigned: boris)

References

Details

Attachments

(4 files)

An example
(deleted), text/html
Details
test.png
(deleted), image/png
Details
Bug 1505225 - Part 1: Make sure we also check the existence of individual transform animations.
(deleted), text/x-phabricator-request
Details
Bug 1505225 - Part 2: Add a reftest.
(deleted), text/x-phabricator-request
Details
Attached file An example (deleted) —
Though this might be done in bug 1425837.
Summary: Individual transform properties' animations don't create stack context in delay phase → Individual transform properties' animations don't create stacking context in delay phase
Depends on: 1526850
Assignee: nobody → boris.chiou
Attached image test.png (deleted) —

I just tried to apply all of my patches of Bug 1425837, Bug 1526847, and Bug 1526850, and can see something like this: blue rectangle overlaps the green one. I guess this is what we expected.

nsIFrame::BuildDisplayListForStackingContext() will check the existence
of transform animations, so we need to update
nsLayoutUtils::HasAnimationsOfPoperty(). However, checking only
eCSSProperty_transform is not enough. We have to check all the transform-like
properties. Therefore, we update these functions to accept a property
set as the argument, and pass a collection of transform-like properties
into them.

Note: The updates in ActiveLayerTracker are not related to this bug, but
I think it's better to update all of them together for supporting
compositor animations on individual transforms later.

Attached file Bug 1505225 - Part 2: Add a reftest. (deleted) —

Depends on D20412

Pushed by boris.chiou@gmail.com: https://hg.mozilla.org/integration/autoland/rev/4ac79195eb46 Part 1: Make sure we also check the existence of individual transform animations. r=hiro https://hg.mozilla.org/integration/autoland/rev/2c10e071b8de Part 2: Add a reftest. r=hiro
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/15484 for changes under testing/web-platform/tests

https://hg.mozilla.org/mozilla-central/rev/4ac79195eb46
https://hg.mozilla.org/mozilla-central/rev/2c10e071b8de

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: