Newsletter template in 64.0b7 has some major issues, with hard-coded values, not represented variables and missing default values. 1. scene2_title doesn't work 2. scene2_newsletter doesn't work. en-US is hard-coded 3. scene2_email_placeholder_text works but no default value 4. scene2_dismiss_button works but no default value Also some visual issues: 5. Privacy policy text and checkbox are misaligned 6. Snippet container is narrower. Also Snippet text looks smaller. I don't know if that a preview side effect? Especially the hard-coding of `scene2_newsletter` would be catastrophic for new non en-US users signing up. Templates must match what we have for the current AS system so we can automatically migrate the hundreds of active Snippets. Ensuring that fields work (i.e. can be populated) and default values are set will shield a proper migration to ASR. I haven't completed testing all implemented templates. Same issues may be applicable to other templates as well. I'm available to help interpret current templates and answer any questions if needed. See also https://github.com/mozmeao/snippets-service/issues/832

Thanks for taking a look, these should be easy enough to fix. It looks like the "locale" variable is used for language in https://github.com/mozmeao/snippets/blob/master/activity-stream/send-to-device.html, am I reading that right? Is that the one that should be fixed? Also, what platform are you testing on for the alignment of the checkbox issue? For the font size issue, I noticed this is inconsistent currently between snippets templates (simple v.s. newsletter, etc.) – I wonder if is that intentional or they should be consistent? Maybe we get Aaron's input on that

(In reply to Kate Hudson :k88hudson from comment #1) > It looks like the "locale" variable is used for language in > https://github.com/mozmeao/snippets/blob/master/activity-stream/send-to- > device.html, am I reading that right? Is that the one that should be fixed? This bug is for the Newsletter template, that's the one I tested, so it should be https://github.com/mozmeao/snippets/blob/master/activity-stream/newsletter-subscribe.html#L22 Send to device template also has locale but I haven't tested that one yet. > Also, what platform are you testing on for the alignment of the checkbox > issue? I'm on Debian Linux > For the font size issue, I noticed this is inconsistent currently between > snippets templates (simple v.s. newsletter, etc.) – I wonder if is that > intentional or they should be consistent? Maybe we get Aaron's input on that Agreed. As far as I understand, Snippets must follow AS styling guidelines, so AS knows better which font size / visuals are appropriate. Any changes should be confirmed by the LCM / Snippets team before committing them.

Commits pushed to master at https://github.com/mozilla/activity-stream https://github.com/mozilla/activity-stream/commit/c96431393be1a1a50c17e3667132927995d44a6a Bug 1505406 - Newsletter compatibility issues https://github.com/mozilla/activity-stream/commit/de57ca2ecbf5f91188fd57d834894e286a3dcbf7 Bug 1505406 - Add more test data for manual QA

Bug 1505929 comment 4 backout link: https://hg.mozilla.org/mozilla-central/rev/4efd19ac076280abf1365b0bb7fd2018ce162b38

Is this something that needs Beta backport consideration or can it ride the trains?

While I was preparing this export I realized I accidentally exported this commit as part of bug 1505406 while I was preparing that uplift – the code is really similar and I must have got wires crossed. Sorry about that.

* as part of 1506838

No worries, thanks for the heads-up. Calling this fixed for 64 by the uplift patch from bug 1506838 then!