In order to allow independent roll-outs for CFR/Snippets/Onboarding features, we need to split configuration into different preferences. We should also ensure this works with the requirements from shield's roll-out mechanism.

Commit pushed to master at https://github.com/mozilla/activity-stream https://github.com/mozilla/activity-stream/commit/ce33c61563cc75372e45e73dfd7c1e7086c93658 Bug 1505551 - Use branch instead of single pref for ASR config

Bug 1505929 comment 4 backout link: https://hg.mozilla.org/mozilla-central/rev/4efd19ac076280abf1365b0bb7fd2018ce162b38

This is going to be needed for us to be able to do a pref roll-out for CFR/Snippets (see also https://bugzilla.mozilla.org/show_bug.cgi?id=1499110)

Comment on attachment 9026521 [details] Uplift: Bug 1505551 - Use branch instead of single preference for ASR configuration [Beta/Release Uplift Approval Request] Feature/Bug causing the regression: Bug 1505551 User impact if declined: We will not be able to roll-out Contextual Feature recommendations or Snippets to users in 64, which are critical to our goals to improve retention, collect appropriate data to make better decisions in the future. Rolling out reduces risks rather than turning everything on at once. (Note that Bug 1499110 is also needed, and should be landed following this one) Is this code covered by automated tests?: Yes Has the fix been verified in Nightly?: Yes Needs manual test from QE?: Yes If yes, steps to reproduce: QA steps for this: Set up devtools using the "Prerequisites" instructions here: https://docs.google.com/document/d/1U8QegwAIXcm3pkznL0mvZ2r0tNXSsnbu9rH82c2dNyQ/edit#heading=h.v67ohgjjeblk Navigate to about:newtab#asrouter. Set the message provider selector to "cfr" and try launching one. Turn on snippets in about:newtab#asrouter, ensure you see snippets show up on the new tab page. Turn them off again, ensure the snippets provider shows up as disabled in about:newtab#asrouter. Check to make sure legacy snippets is running (inspect new tab page, find snippets-container element, ensure there is some inner HTML in it) Navigate to about:welcome, ensure you see onboarding List of other uplifts needed: Bug 1499110 Risk to taking this patch: Low Why is the change risky/not risky? (and alternatives if risky): Patch has been running in nightly for at least a week, has been covered by manual and automated testing String changes made/needed:

I have verified this fix on the latest Nightly 65.0a1 (Build ID 20181121220101) on Windows 10, Mac 10.13.3, and Arch Linux.

Comment on attachment 9026521 [details] Uplift: Bug 1505551 - Use branch instead of single preference for ASR configuration tweak AS preferences for rollouts, approved for 64.0b12

I have verified the fix on the latest Beta build 64.0b12 (Build ID 20181122182000) on Windows 10 x64, Mac 10.13.3, and Arch Linux 4.16.