Closed
Bug 1505666
Opened 6 years ago
Closed 6 years ago
testGCUniqueId tests GC moving in the wrong order
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: pbone, Assigned: pbone)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
https://searchfox.org/mozilla-central/source/js/src/jsapi-tests/testGCUniqueId.cpp#97-118 This code: 1. Allocates an array of things. 2. Punches holes in the array making some things unreachable. 3. Does a GC that might compact 4. Chooses and object and takes its address 5. Does a compacting GC 6. Compares the objects's old and new pointers expecting it to move. However if the first GC was a compacting GC then the object will have moved then and won't move in the 2nd compacting GC.
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Updated•6 years ago
|
Attachment #9023515 -
Flags: review?(jcoppeard) → review-
|
||
Updated•6 years ago
|
Attachment #9023515 -
Flags: review- → review+
Pushed by pbone@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c7705516c1e3 Fix order of operations in the testGCUniqueId test r=jonco
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c7705516c1e3
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•