Closed Bug 1505864 Opened 6 years ago Closed 6 years ago

Bookmark folder icons almost invisible when placed in another folder on the Bookmarks Toolbar, if the theme is set to dark

Categories

(Firefox :: Theme, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 65
Tracking Status
firefox-esr60 --- unaffected
firefox63 --- unaffected
firefox64 --- unaffected
firefox65 --- verified

People

(Reporter: itiel_yn8, Assigned: dao)

References

Details

(Keywords: regression)

Attachments

(2 files)

Attached image Screenshot (deleted) —
STR: 1. Set Nightly's theme to dark 2. Enable the Bookmarks Toolbar 3. Create a folder on the toolbar (so far so good) 4. Create another folder in the folder in step #3 5. Optional: overflow the Bookmarks Toolbar with more bookmarks than it can contain, and place a folder in the "Show more bookmarks" button AR: The folder icons are nearly invisible. ER: Visible folder icons. See attached screnshot. This is a regression from bug 1505311.
Flags: needinfo?(dao+bmo)
This seems like a bug in the icon_color implementation...
Blocks: 1347184
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Flags: needinfo?(dao+bmo)
OS: Unspecified → All
Priority: -- → P1
Hardware: Unspecified → All
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/727d38ff4a3e Stop using --lwt-toolbarbutton-icon-fill for bookmark menu items. r=jaws
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Fixed on latest Nightly.
Status: RESOLVED → VERIFIED
Has STR: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: