Closed Bug 1505915 Opened 6 years ago Closed 5 years ago

[Fission] Make View Source Fission-aware

Categories

(Toolkit :: View Source, task, P3)

Product:
Toolkit
Component:
View Source
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla74
Project Flags:
Fission Milestone M4.1
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: Felipe, Assigned: enndeakin)

References

Details

Attachments

(1 file)

Bug 1505915, move view source components to use JSWindowActor. This allows view frame source to work in out of process child frames, r=mconley
(deleted), text/x-phabricator-request
Details
The test toolkit/components/viewsource/test/browser/browser_srcdoc.js fails when using the browser.fission.simulate pref. I didn't dig deeper yet, but it's likely that the feature will need more changes to be compatible with Fission, related to viewing the source of subframes (This Frame -> View Source) and View Selection Source
Fission Milestone: --- → Future
Fission Milestone: Future → M4
Type: enhancement → task
Fission Milestone: M4 → M5
Assignee: nobody → jahnsjam
Summary: [Fission] Make View Source Fission-aware → [MSU Capstone][Fission] Make View Source Fission-aware
Assignee: jahnsjam → nobody
No longer blocks: 1574175
Summary: [MSU Capstone][Fission] Make View Source Fission-aware → [Fission] Make View Source Fission-aware

M4.1 because this bug is about a test. View Source works for me in the browser.

Fission Milestone: M5 → M4.1

Honza, this bug currently blocks Fission's current milestone (M4.1 aka "fix all the mochitests"), but it's unassigned.

Is this bug still valid? View Source works for me in the browser and the browser_srcdoc.js mentioned in comment 0 does not appear to be skipped or fail-if Fission:

https://searchfox.org/mozilla-central/rev/6305f6935f496b3a302c7afcc579399a4217729c/toolkit/components/viewsource/test/browser/browser.ini#12

Flags: needinfo?(odvarko)

I have a patch for this. View Source works fine as is, but viewing a child frame's source from the context menu does not.

The test bug482921-2.xhtml isn't marked as disabled for fission. Some of the others in that reftest.list are but don't look to be related to view source, so i don't think there is anything to do here testwise.

Flags: needinfo?(odvarko)
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
Pushed by neil@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/deea1e560289 move view source components to use JSWindowActor. This allows view frame source to work in out of process child frames, r=mconley

https://hg.mozilla.org/mozilla-central/rev/deea1e560289

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
Duplicate of this bug: 1171986
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: