[Fission] Make the fullscreen code Fission-aware
Categories
(Firefox :: General, enhancement, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox71 | --- | fixed |
People
(Reporter: Felipe, Assigned: ablayelyfondou)
References
Details
Attachments
(2 files)
Comment 1•6 years ago
|
||
Reporter | ||
Comment 2•6 years ago
|
||
Updated•6 years ago
|
Updated•6 years ago
|
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 3•5 years ago
|
||
Updated•5 years ago
|
Updated•5 years ago
|
Comment 5•5 years ago
|
||
Hi Abdoulaye, were you still working on this?
Updated•5 years ago
|
Assignee | ||
Comment 7•5 years ago
|
||
e10s scenario:
- A DOM element request fullscreen mode.
- The request is redirected to the parent.
- Parent enters fullscreen.
- Parent notifies child that it has finished entering fullscreen.
- Child goes fullscreen.
- Then, child notifies parent that it has finished transitioning to fullscreen.
- Finally, parent notifies observers that fullscreen paint has finished.
Let's go into the details of how step 5 works in the above scenario.
5.a The element that made the request is set to fullscreen.
5.b Then, the document where that element lives is set to fullscreen as well as all of its ancestors until we reach the top-level document. (see Document::ApplyFulscreen method)
Now in Fission world, we may have a request coming from an oop iframe. And it that case since we won't be able to directly access to ancestor documents living in different content processes anymore, we will first notify those content processes (one after the other from bottom to top) to go fullscreen. Once they all do, the content process where the request originated from will be told to enter fullscreen. And then the process continues to step 6...
Updated•5 years ago
|
Comment 8•5 years ago
|
||
Dao and smaug, please review the patches.
Comment 9•5 years ago
|
||
No need to needinfo when the patch is in review queue.
Comment 10•5 years ago
|
||
Hey Abdoulaye - I notice you've got prior approval on the reviews for Part 1, and just got approval on Part 2 yesterday. Is this pretty close to being landable?
Assignee | ||
Comment 11•5 years ago
|
||
Yes it is, I am just waiting for dao approval here.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Comment 13•5 years ago
|
||
I conferred with Abdoulaye outside of Bugzilla - it sounds like he's sorted things out with Dao in Phabricator, and try looks okay (https://treeherder.mozilla.org/#/jobs?repo=try&revision=18dd6d6f49252a373d35cb12f7d53e86d102a540), so going to try to land these now.
Comment 14•5 years ago
|
||
Comment 15•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8b47aa47a640
https://hg.mozilla.org/mozilla-central/rev/fcaa0242c204
Updated•5 years ago
|
Updated•5 years ago
|
Description
•