When the declaration is moved to a single line, I am getting: TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/xpcom/base/nsCycleCollectionParticipant.h:592 | Virtual function declarations should specify only one of `virtual`, `final`, or `override` (cpp-virtual-final) with linting opt source-test-mozlint-cpp-virtual-final (cvf)

Avoid lint cpp-virtual-final false positive

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0f9d5e93e0ba Add clang-format off to keep the line the same way r=andi

Comment on attachment 9023963 [details] Bug 1505943 - Add clang-format off to keep the line the same way r?andi [ESR Uplift Approval Request] If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is required for easier backporting of patches after the reformatting of ESR using clang-format. User impact if declined: Declining this will negatively impact our developers' ability to easily backport their patches to ESR in the future. Fix Landed on Version: 65 Risk to taking this patch: Low Why is the change risky/not risky? (and alternatives if risky): Comment additions only, should not change anything in the binary. Has also been tested in Nightly for a couple of months or so.. String or UUID changes made by this patch: None

Comment on attachment 9023963 [details] Bug 1505943 - Add clang-format off to keep the line the same way r?andi OK for uplift to ESR60 as part of the clang-format project.