Julian Descottes [:jdescottes] Assignee
	Description • 6 years ago

In bug 1497917 we are introducing a wrapper around the client object. This wrapper allows to isolate the complexity related to interacting with the client and makes it easier to create mocks in our tests.

From an external contributor point of view, it might be strange to see the code in the module doing things such as `await client.getDeviceDescription();` while getDeviceDescription is not a method available on DebuggerClient. 

We should rename the client property of runtimeDetails to clientWrapper to avoid confusion.

https://searchfox.org/mozilla-central/rev/17f55aee76b7c4610a974cffd3453454e0c8de7b/devtools/client/aboutdebugging-new/src/types.js#34

	Julian Descottes [:jdescottes] Assignee
	Comment 1 • 6 years ago

Taking this right now, otherwise the review for Bug 1497457 will be quite painful

	Julian Descottes [:jdescottes] Assignee
	Comment 2 • 6 years ago

Note that I fixed the worker bug at the same time. We can keep your other bug to add a test.

	Pulsebot
	Comment 3 • 6 years ago

Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5cc584ca5b00
Rename runtimeDetails.client to clientWrapper;r=daisuke

	Cosmin Sabou [:CosminS]
	Comment 4 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/5cc584ca5b00