Closed
Bug 1506117
Opened 6 years ago
Closed 6 years ago
layout/style/nsCSSKeywordList.h: do not format
Categories
(Developer Infrastructure :: Lint and Formatting, defect)
Developer Infrastructure
Lint and Formatting
Tracking
(firefox-esr60 fixed, firefox65 fixed)
RESOLVED
FIXED
mozilla65
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
lizzard
:
approval-mozilla-esr60+
|
Details |
causes issues like:
TEST-UNEXPECTED-FAIL | /css/css-flexbox/getcomputedstyle/flexbox_computedstyle_align-items-flex-start.html | flexbox | computed style | align-items: flex-start - assert_equals: expected "flex-start" but got "flex - start"
Assignee | ||
Updated•6 years ago
|
Version: 60 Branch → unspecified
Assignee | ||
Comment 1•6 years ago
|
||
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9349b769c389
layout/style/nsCSSKeywordList.h: do not format r=andi
Comment 3•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Updated•6 years ago
|
Assignee: nobody → sledru
Comment 4•6 years ago
|
||
Comment on attachment 9023954 [details]
Bug 1506117 - layout/style/nsCSSKeywordList.h: do not format r?andi
[ESR Uplift Approval Request]
If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is required for easier backporting of patches after the reformatting of ESR using clang-format.
User impact if declined: Declining this will negatively impact our developers' ability to easily backport their patches to ESR in the future.
Fix Landed on Version: 65
Risk to taking this patch: Low
Why is the change risky/not risky? (and alternatives if risky): NPOTB
String or UUID changes made by this patch: None
Attachment #9023954 -
Flags: approval-mozilla-esr60?
status-firefox-esr60:
--- → affected
Comment on attachment 9023954 [details]
Bug 1506117 - layout/style/nsCSSKeywordList.h: do not format r?andi
OK for uplift to ESR60 as part of the clang-format project.
Attachment #9023954 -
Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
Comment 6•6 years ago
|
||
bugherder uplift |
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•