Closed
Bug 1506371
Opened 6 years ago
Closed 6 years ago
Help > about Nightly say "Nightly is up to date"
Categories
(Toolkit :: Application Update, defect)
Tracking
()
VERIFIED
FIXED
mozilla65
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox63 | --- | unaffected |
firefox64 | --- | unaffected |
firefox65 | --- | verified |
People
(Reporter: alice0775, Assigned: robert.strong.bugs)
References
Details
(Keywords: regression)
Attachments
(2 files, 1 obsolete file)
(deleted),
image/png
|
Details | |
(deleted),
patch
|
bytesized
:
review+
|
Details | Diff | Splinter Review |
Reproduced the bug since 20181109101751.
Steps to reproduce:
if you have installed Nightly skip step 1 and step 2.
1. Download a Nightly build and extract it to folder A
2. Launch Nightly from folder A
3. Updete Nightly from Help menu, restart, then completely quit
4. Download an old Nightly same locale build[1] or later but not latest and extract it to folder B
[1]http://archive.mozilla.org/pub/firefox/nightly/2018/11/2018-11-09-10-17-51-mozilla-central/firefox-65.0a1.en-US.win64.zip
5. Launch Nightly[1] with new profile
3. Help > About Nightly
Actual Results:
Nightly say "Nightly is unable to update" but build date is old.
However after for about few minutes, the uptate process is automatically start
Browser console shows the following error:
TypeError: this.aus is undefined; can't access its "getAutoUpdateIsEnabled" property[Learn More] aboutDialog-appUpdater.js:260:9
onCheckComplete
chrome://browser/content/aboutDialog-appUpdater.js:260:9
UC_onLoad
jar:file:///L:/trunk/2018/11/firefox09-Nov-2018 101751 Nightly/omni.ja!/components/nsUpdateService.js:3398:7
UC_checkForUpdates/</<
jar:file:///L:/trunk/2018/11/firefox09-Nov-2018 101751 Nightly/omni.ja!/components/nsUpdateService.js:3296:64
Expected Results:
Nightly should start update process immediately
Regression Window
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=12cc80a0e9968ade961879ee07effb815da691f0&tochange=5e7636ec12c5c4543b64428e15165031cff32dc4
Seems triggered by: Bug 1503362
@:bytesized,
can you please look into this?
Flags: needinfo?(ksteuber)
Comment 1•6 years ago
|
||
I'm actually leaning towards bug 1458308 in that bucket, which added that line.
s/this.aus.getAutoUpdateIsEnabled/gAppUpdater.aus.getAutoUpdateIsEnabled/ ?
Comment 2•6 years ago
|
||
More data: The preference pane update check seems to use the same code, I get the same error.
Unprompted software update just worked for me, I updated to https://hg.mozilla.org/mozilla-central/rev/39dba5141dd90c70a861299459d418d230148d9f.
Reporter | ||
Comment 3•6 years ago
|
||
Even if update prompt panel pops up, "About Nightly" say "Nightly is up to date"...
Comment 4•6 years ago
|
||
Just posting to confirm, as above, that a single install of Nightly behaves the same way as the original reporter describes -- wait for the next update to be available and Help->About continues to display "Nightly is up to date". This has been happening for at least three days, if that's any help.
Reporter | ||
Updated•6 years ago
|
Summary: Help > about Nightly say "Nightly is up to date" if another Nightly(installed to different folder) had been updated to the latest → Help > about Nightly say "Nightly is up to date"
Comment 6•6 years ago
|
||
Just talked to Robert on IRC and he says he has a fix for this.
Flags: needinfo?(ksteuber) → needinfo?(robert.strong.bugs)
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → robert.strong.bugs
Status: NEW → ASSIGNED
Flags: needinfo?(robert.strong.bugs)
Assignee | ||
Comment 7•6 years ago
|
||
Keeping this patch simple and will make the other changes in a new bug
Assignee | ||
Comment 8•6 years ago
|
||
Assignee | ||
Comment 9•6 years ago
|
||
Comment on attachment 9024696 [details] [diff] [review]
patch rev1
Please also note the change to using a strict equality check
gAppUpdater.promiseAutoUpdateSetting === null
Attachment #9024696 -
Flags: review?(ksteuber)
Assignee | ||
Comment 11•6 years ago
|
||
Discussed the strict equality check with bytesized and decided it isn't needed.
Attachment #9024696 -
Attachment is obsolete: true
Attachment #9024696 -
Flags: review?(ksteuber)
Attachment #9024802 -
Flags: review?(ksteuber)
Updated•6 years ago
|
Attachment #9024802 -
Flags: review?(ksteuber) → review+
Assignee | ||
Updated•6 years ago
|
Comment 12•6 years ago
|
||
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d856ddbfc64
Updating via Help > About broken on Nightly. r=bytesized
Comment 13•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Comment 14•6 years ago
|
||
When I open the About Firefox dialog, I get: ReferenceError: reference to undefined property "promiseAutoUpdateSetting"[Learn More] aboutDialog-appUpdater.js:43:3
Assignee | ||
Comment 15•6 years ago
|
||
(In reply to Richard Marti (:Paenglab) from comment #14)
> When I open the About Firefox dialog, I get: ReferenceError: reference to
> undefined property "promiseAutoUpdateSetting"[Learn More]
> aboutDialog-appUpdater.js:43:3
Thanks, I'll take care of that in bug 1506915 since I'll have to update the call sites.
Updated•6 years ago
|
Flags: qe-verify+
Comment 16•6 years ago
|
||
I’ve couldn't reproduce the issue by following the steps mentioned in description. But I’ve manage to see the updating problem, using another workaround on Windows 10 x64:
- Downloaded Fx 65.0a1 (2018-11-10) build and change the default channel
- Open the browser and make sure 'Check for updates but let you choose to install them' on about:preferences page is set
- Change the channel back to “nightly” and restart the browser
The issue is verified as fixed with Nightly 67.0a1 (2019-02-01) and RC 65.0 (build 1 - 20190121133710) on Windows 10 x64, Ubuntu 18.04 x64 and macOS 10.13.
You need to log in
before you can comment on or make changes to this bug.
Description
•