I recently got an assertion when testing accessibility builds, where we assert because we can't load a manifest from DLL resources. The problem, however, is more general. It looks like all object files are missing resources (a quick test is to see if firefox.exe has its icon in Windows Explorer). I think this worked before. I found an old build from July that had resources right, so this is a regression.

Hrm. The earliest successful build I can find myself has having sent to try is at https://treeherder.mozilla.org/#/jobs?repo=try&revision=ae5d52b409ce46a1f469b105e6a4c255270c411f which I recreated at https://treeherder.mozilla.org/#/jobs?repo=try&revision=8ef77754a1d898f1f3a28f48b359be26ca975542 It is missing the icon in Windows Explorer. But yea I agree I seem to remember the icon from some time ago... Does about:buildconfig on that build give you anything useful to narrow down the mingw or clang version it was built with?

Before looking at regression in current build config, I experimented with using llvm-rc (instead of binutils windres) and results seem promising. Technically, we could invoke llvm-rc directly (like we invoke rc.exe in clang-cl builds), but the assumption that mingw uses windres is pretty deep in build system. I used Martin's windres wrapper around llvm-rc from mingw-llvm: https://github.com/mstorsjo/llvm-mingw/blob/master/wrappers/windres-wrapper.c Such toolchain generates binaries that include resources: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6983298b55203dc98962fcf38b42ac9658f6e840 Patch for the toolchain looks like this: https://hg.mozilla.org/try/rev/9c228997570864a286f8cf59f108622465ab1ffa It has two problems that need to be solved first: - Windows doesn't like something about the manifest, which prevents firefox.exe to be ran - llvm-rc doesn't know about EXSTYLE and NOT keywords in .rc files. This should be easy to add, a workaround I used for testing is: https://hg.mozilla.org/try/rev/42db220ddec6013bb25e0adbda1980e637daad7f

EXSTYLE is supported by llvm-rc now: https://reviews.llvm.org/rL347858

NOT expressions landed as well: https://reviews.llvm.org/D55242 Here is try with all this: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b05eb1464bae9ee45fa7fd6b92fe98082b78dce3 With one more patch, Firefox is able to launch: https://treeherder.mozilla.org/#/jobs?repo=try&revision=20b6835f2fcfbc9cd23a49a04256e9e94b54d769

We don't need binutils for that anymore (and using binutils windres was broken for some reason).

Pushed by jacek@codeweavers.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3e75f80fd784 Bump LLVM and mingw-w64 versions. r=froydnj https://hg.mozilla.org/integration/mozilla-inbound/rev/8dcdfbc80345 Use llvm-rc via mingw-llvm windres wrapper as resource compiler. r=froydnj

https://hg.mozilla.org/mozilla-central/rev/3e75f80fd784 https://hg.mozilla.org/mozilla-central/rev/8dcdfbc80345

Here is a backported version; but it may need rebasing depending on what the order of patches landing is. Successful try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fafd2ead717c43016c2ef1cfcc241ff95f4015b2