Closed Bug 1506548 Opened 6 years ago Closed 6 years ago

RootFront.listWorkers should return WorkerTargetFront rather than JSON forms

Categories

(DevTools :: Framework, enhancement, P2)

enhancement

Tracking

(firefox65 fixed)

RESOLVED FIXED
Firefox 65
Tracking Status
firefox65 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

(Whiteboard: dt-fission)

Attachments

(3 files)

Today, WorkerTargetFront is instantiated by TargetFactory.forWorker callsites like this one: https://searchfox.org/mozilla-central/rev/06d5d5ae4396be85f26e8548323ee6c12e7bce4e/devtools/client/debugger/new/panel.js#71-73 const [response, workerTargetFront] = await this.toolbox.target.client.attachWorker(worker.actor); const workerTarget = TargetFactory.forWorker(workerTargetFront); But we should rather let protocol.js auto-marshalling instantiate all the fronts, here, during RootFront.listWorkers request.
Assignee: nobody → poirot.alex
MozReview-Commit-ID: 1viBxZ8hHGk
MozReview-Commit-ID: 8FZbi4KQzCn Depends on D11761
MozReview-Commit-ID: 4CBQNwC8tKq Depends on D11762
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8a421a0addad Remove last references to remote targets from target.js. r=yulia https://hg.mozilla.org/integration/autoland/rev/fc303dfddb35 Prevent displaying memory and netmonitor panels for workers. r=yulia https://hg.mozilla.org/integration/autoland/rev/d279007bde1a Return WorkerTargetFront from listWorkers instead of form. r=yulia
Depends on: 1509315
No longer depends on: 1509315
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: