Closed Bug 1506611 Opened 6 years ago Closed 1 year ago

Enable flake8 linter on more directories under /testing

Categories

(Testing :: General, task, P3)

task

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: ahal, Unassigned)

References

Details

Attachments

(3 files)

Here are the remaining directories with errors: testing/awsy: 94 errors testing/firefox-ui: 6 errors testing/geckodriver: 17 errors testing/gtest: 19 errors testing/jsshell: 1 error testing/marionette: 352 errors testing/mozharness: 806 errors testing/runtimes: 10 errors testing/tools: 72 errors testing/tps: 57 errors testing/web-platform: 6473 errors Let's at least use this bug to tackle the low-hanging fruit (<50 errors). Some of the larger directories will warrant their own bug.
FWIW I don’t particularly think it’s time well spent to fix testing/marionette before we figure out which Mn tests are duplicated in WPT (Wd). I am also working on a deprecation plan for the Marionette Python client, but we will keep maintaining it for internal use for the foreseeable future. Fixing any lint problems specifically with testing/marionette/client/marionette_driver/**/*.py and testing/marionette/harness/marionette_harness/*.py (excluding its test subdirectory) might be worthwhile.
Also, presumably testing/web-platform has its own linting system.
Priority: -- → P3
Before this change, testing/awsy had 94 errors and testing/geckodriver had 17. The errors have been reduced to 8 and 1 respectively.
Pushed by ahalberstadt@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/41e4eb2f9e47 Fixed linter errors in testing/awsy and testing/geckodriver r=ahal
Keywords: leave-open
Before this change, testing/gtest had 19 errors. These errors have been resolved. Bug 1506611 - Fixed flake8 errors in testing/gtest
Version: Version 3 → unspecified
thanks for doing that work :)
Assignee: nobody → terrameijar
Pushed by ahalberstadt@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/807f9818930a Fixed linter errors in testing/gtest r=ahal
Before this change, testing/tps had 19 linter errors. These have been resolved.

The leave-open keyword is there and there is no activity for 6 months.
:gbrown, maybe it's time to close this bug?

Flags: needinfo?(gbrown)
Type: defect → task

We've come a long way but it looks like there is more to do - let's keep the bug for now.

Flags: needinfo?(gbrown)
Keywords: leave-open

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.

Assignee: terrameijar → nobody
Severity: normal → S3

As of Bug 1811850, we now use ruff instead of flake8. Closing as WONTFIX.

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: