Closed
Bug 1506653
Opened 6 years ago
Closed 6 years ago
pageAction needs to support showInPrivateBrowsing
Categories
(WebExtensions :: Frontend, enhancement, P1)
WebExtensions
Frontend
Tracking
(firefox66 fixed)
RESOLVED
FIXED
mozilla66
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: mixedpuppy, Assigned: mixedpuppy)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
CUI widgets have showInPrivateBrowsing which defaults to true. This allows us to turn off browserAction. PageActions.jsm do not appear to have a similar flag. This is to cover supporting both that and ext-pageAction in webextensions.
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → mixedpuppy
Priority: -- → P1
|
|
Assignee | |
Comment 2•6 years ago
|
||
|
|
Assignee | |
Comment 3•6 years ago
|
||
|
|
Assignee | |
Comment 4•6 years ago
|
||
Pushed by mixedpuppy@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/2d0a91485b6b
support disabling page action for private windows, r=Gijs
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in
before you can comment on or make changes to this bug.
Description
•