Closed
Bug 1506658
Opened 6 years ago
Closed 6 years ago
Ensure public API has appropriate nullability annotations
Categories
(GeckoView :: General, defect, P1)
GeckoView
General
Tracking
(geckoview64 wontfix, geckoview65 wontfix, firefox-esr60 wontfix, firefox63 wontfix, firefox64 wontfix, firefox65 wontfix, firefox66 fixed)
RESOLVED
FIXED
mozilla66
People
(Reporter: snorp, Assigned: agi)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
text/x-phabricator-request
|
Details |
That means all non-primitive arguments and return values need to have @Nullable or @NotNull.
|
Assignee | |
Comment 1•6 years ago
|
||
We can probably do this together with https://github.com/mozilla-mobile/gradle-apilint/issues/2 with a generic "ensure that every API has an annotation in this set" lint.
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → agi
|
||
Comment 2•6 years ago
|
||
A-C has asked for nullability annotations.
status-firefox63:
--- → wontfix
status-firefox64:
--- → fix-optional
status-firefox65:
--- → affected
Priority: -- → P1
|
|
Assignee | |
Updated•6 years ago
|
status-firefox63:
wontfix → ---
status-firefox64:
fix-optional → ---
status-firefox65:
affected → ---
Depends on: 1506267
Priority: P1 → --
|
|
Assignee | |
Comment 3•6 years ago
|
||
Sorry restoring flags :)
status-firefox63:
--- → wontfix
status-firefox64:
--- → fix-optional
status-firefox65:
--- → affected
Priority: -- → P1
|
|
||
Comment 4•6 years ago
|
||
64=wontfix because this bug doesn't need to block Focus 8.0.
|
||
Updated•6 years ago
|
Depends on: external-gv-ergonomics
|
|
||
Updated•6 years ago
|
Blocks: external-gv-ergonomics
No longer depends on: external-gv-ergonomics
|
|
Assignee | |
Comment 5•6 years ago
|
||
Upgrading apilint to the 0.1.6 release will also ensure that new APIs have
nullability annotations via the GV4 and GV5 lints, see [0].
[0]: https://github.com/mozilla-mobile/gradle-apilint/commit/b994c7ca9db056652ba4b5dd639437ddf2c5cc6f#diff-2c7de691a2642510f69b9ddf59276d85R569
|
|
Assignee | |
Comment 6•6 years ago
|
||
Upgrading apilint to the 0.1.6 release will also ensure that new APIs have
nullability annotations via the GV4 and GV5 lints, see [0].
[0]: https://github.com/mozilla-mobile/gradle-apilint/commit/b994c7ca9db056652ba4b5dd639437ddf2c5cc6f#diff-2c7de691a2642510f69b9ddf59276d85R569
|
||
Updated•6 years ago
|
Attachment #9032524 -
Attachment is obsolete: true
|
|
||
Updated•6 years ago
|
Attachment #9032251 -
Attachment description: Bug 1506658 - Add @Nullable or @NonNull to all APIs. r?snorp!,rbarker!,esawin! → Bug 1506658 - Add @Nullable or @NonNull to all APIs. r=snorp!,rbarker!,esawin!
|
|
||
Updated•6 years ago
|
Attachment #9032251 -
Attachment description: Bug 1506658 - Add @Nullable or @NonNull to all APIs. r=snorp!,rbarker!,esawin! → Bug 1506658 - Add @Nullable or @NonNull to all APIs. r=snorp!,rbarker!
Pushed by asferro@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/12616753519d
Add @Nullable or @NonNull to all APIs. r=snorp,rbarker,geckoview-reviewers
|
||
Updated•6 years ago
|
Product: Firefox for Android → GeckoView
|
||
Comment 8•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
|
|
||
Comment 9•6 years ago
|
||
65=wontfix because we don't need to uplift this lint check.
status-firefox-esr60:
--- → wontfix
status-geckoview64:
--- → wontfix
status-geckoview65:
--- → wontfix
|
||
Updated•6 years ago
|
Target Milestone: Firefox 66 → mozilla66
You need to log in
before you can comment on or make changes to this bug.
Description
•