Closed Bug 1506706 Opened 6 years ago Closed 6 years ago

Add tab properties so Marionette can run on Thunderbird

Categories

(Thunderbird :: Testing Infrastructure, enhancement)

Product:
Thunderbird
Component:
Testing Infrastructure
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 65.0

People

(Reporter: darktrojan, Assigned: darktrojan)

References

Details

Attachments

(1 file, 2 obsolete files)

1506706-marionette-3.diff
(deleted), patch
mkmelin
: review+
Details | Diff | Splinter Review
Here's the changes needed in Thunderbird to match bug 1506523.
Attached patch 1506706-marionette-1.diff (obsolete) (deleted) — — Splinter Review
Attachment #9024572 - Flags: review?(mkmelin+mozilla)
Attached patch 1506706-marionette-2.diff (obsolete) (deleted) — — Splinter Review
Added the code to package Marionette, which I found in another patch but should be here.
Attachment #9024572 - Attachment is obsolete: true
Attachment #9024572 - Flags: review?(mkmelin+mozilla)
Attachment #9025184 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9025184 [details] [diff] [review] 1506706-marionette-2.diff Review of attachment 9025184 [details] [diff] [review]: ----------------------------------------------------------------- LGTM, r=mkmelin
Attachment #9025184 - Flags: review?(mkmelin+mozilla) → review+
Attached patch 1506706-marionette-3.diff (deleted) — — Splinter Review
It turns out neither of those tabmail.xml changes did what I thought they did. This one does though, and allows me to simplify my m-c patch.
Attachment #9025184 - Attachment is obsolete: true
Attachment #9025790 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9025790 [details] [diff] [review] 1506706-marionette-3.diff Review of attachment 9025790 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thx! r=mkmelin
Attachment #9025790 - Flags: review?(mkmelin+mozilla) → review+
This might as well land, bug 1506523 is on mozilla-inbound now.
Keywords: checkin-needed
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/7f0dd2a068dc Add tab properties so Marionette can run on Thunderbird. r=mkmelin
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 65.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: