Closed Bug 1507312 Opened 6 years ago Closed 6 years ago

Update Debugger Frontend v102

Categories

(DevTools :: Debugger, defect, P3)

defect

Tracking

(firefox65 fixed)

RESOLVED FIXED
Firefox 65
Tracking Status
firefox65 --- fixed

People

(Reporter: loganfsmyth, Assigned: loganfsmyth)

References

Details

Attachments

(2 files)

Backed out changeset for damp failures on debugger/custom.js. Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed&fromchange=e368528459474eedea833311aea43cacc85c36ee&tochange=dea39df5254abb0b39ef52cbbc83dc5a0e7755d6&searchStr=linux%2Cx64%2Cquantumrender%2Copt%2Ctalos%2Cperformance%2Ctests%2Cwith%2Ce10s%2Ctest-linux64-qr%2Fopt-talos-damp-e10s%2Ct-e10s%28damp%29&selectedJob=212293688 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=212293688&repo=autoland&lineNumber=910 Backout link: https://hg.mozilla.org/integration/autoland/rev/dea39df5254abb0b39ef52cbbc83dc5a0e7755d6 12:09:53 ERROR - PID 3634 | TEST-UNEXPECTED-FAIL | damp | debugger/custom.js: TypeError: dbg.selectors.getBreakpoints is not a function 12:09:53 INFO - PID 3634 | removeBreakpoints@file:///tmp/tmpnBWgwx/profile/extensions/bug1150215@mozilla.org">bug1150215@mozilla.org/content/tests/debugger/debugger-helpers.js:252:23 12:09:53 INFO - PID 3634 | async*pauseDebuggerAndLog@file:///tmp/tmpnBWgwx/profile/extensions/bug1150215@mozilla.org">bug1150215@mozilla.org/content/tests/debugger/custom.js:53:9 12:09:53 INFO - PID 3634 | async*module.exports@file:///tmp/tmpnBWgwx/profile/extensions/bug1150215@mozilla.org">bug1150215@mozilla.org/content/tests/debugger/custom.js:30:9 12:09:53 INFO - PID 3634 | async*_runNextTest@file:///tmp/tmpnBWgwx/profile/extensions/bug1150215@mozilla.org">bug1150215@mozilla.org/content/damp.js:268:19 12:09:53 INFO - PID 3634 | testTeardown@file:///tmp/tmpnBWgwx/profile/extensions/bug1150215@mozilla.org">bug1150215@mozilla.org/content/damp.js:226:5 12:09:53 INFO - PID 3634 | async*exports.testTeardown@file:///tmp/tmpnBWgwx/profile/extensions/bug1150215@mozilla.org">bug1150215@mozilla.org/content/tests/head.js:46:10 12:09:53 INFO - PID 3634 | module.exports@file:///tmp/tmpnBWgwx/profile/extensions/bug1150215@mozilla.org">bug1150215@mozilla.org/content/tests/inspector/custom.js:23:9 12:09:53 INFO - PID 3634 | async*_runNextTest@file:///tmp/tmpnBWgwx/profile/extensions/bug1150215@mozilla.org">bug1150215@mozilla.org/content/damp.js:268:19 12:09:53 INFO - PID 3634 | testTeardown@file:///tmp/tmpnBWgwx/profile/extensions/bug1150215@mozilla.org">bug1150215@mozilla.org/content/damp.js:226:5 12:09:53 INFO - PID 3634 | async*exports.testTeardown@file:///tmp/tmpnBWgwx/profile/extensions/bug1150215@mozilla.org">bug1150215@mozilla.org/content/tests/head.js:46:10 12:09:53 INFO - PID 3634 | module.exports@file:///tmp/tmpnBWgwx/profile/extensions/bug1150215@mozilla.org">bug1150215@mozilla.org/content/tests/webconsole/custom.js:23:9 12:09:53 INFO - PID 3634 | async*_runNextTest@file:///tmp/tmpnBWgwx/profile/extensions/bug1150215@mozilla.org">bug1150215@mozilla.org/content/damp.js:268:19 12:09:53 INFO - PID 3634 | testTeardown@file:///tmp/tmpnBWgwx/profile/extensions/bug1150215@mozilla.org">bug1150215@mozilla.org/content/damp.js:226:5 12:09:53 INFO - PID 3634 | async*exports.testTeardown@file:///tmp/tmpnBWgwx/profile/extensions/bug1150215@mozilla.org">bug1150215@mozilla.org/content/tests/head.js:46:10 12:09:53 INFO - PID 3634 | module.exports@file:///tmp/tmpnBWgwx/profile/extensions/bug1150215@mozilla.org">bug1150215@mozilla.org/content/tests/netmonitor/complicated.js:29:9 12:09:53 INFO - PID 3634 | async*_runNextTest@file:///tmp/tmpnBWgwx/profile/extensions/bug1150215@mozilla.org">bug1150215@mozilla.org/content/damp.js:268:19 12:09:53 INFO - PID 3634 | testTeardown@file:///tmp/tmpnBWgwx/profile/extensions/bug1150215@mozilla.org">bug1150215@mozilla.org/content/damp.js:226:5 12:09:53 INFO - PID 3634 | async*exports.testTeardown@file:///tmp/tmpnBWgwx/profile/extensions/bug1150215@mozilla.org">bug1150215@mozilla.org/content/tests/head.js:46:10 12:09:53 INFO - PID 3634 | module.exports@file:///tmp/tmpnBWgwx/profile/extensions/bug1150215@mozilla.org">bug1150215@mozilla.org/content/tests/styleeditor/complicated.js:15:9 12:09:53 INFO - PID 3634 | async*_runNextTest@file:///tmp/tmpnBWgwx/profile/extensions/bug1150215@mozilla.org">bug1150215@mozilla.org/content/damp.js:268:19 12:09:53 INFO - PID 3634 | testTeardown@file:///tmp/tmpnBWgwx/profile/extensions/bug1150215@mozilla.org">bug1150215@mozilla.org/content/damp.js:226:5 12:09:53 INFO - PID 3634 | async*exports.testTeardown@file:///tmp/tmpnBWgwx/profile/extensions/bug1150215@mozilla.org">bug1150215@mozilla.org/content/tests/head.js:46:10 12:09:53 INFO - PID 3634 | module.exports@file:///tmp/tmpnBWgwx/profile/extensions/bug1150215@mozilla.org">bug1150215@mozilla.org/content/tests/debugger/complicated.js:24:9 12:09:53 INFO - PID 3634 | async*_runNextTest@file:///tmp/tmpnBWgwx/profile/extensions/bug1150215@mozilla.org">bug1150215@mozilla.org/content/damp.js:268:19 12:09:53 INFO - PID 3634 | testTeardown@file:///tmp/tmpnBWgwx/profile/extensions/bug1150215@mozilla.org">bug1150215@mozilla.org/content/damp.js:226:5 12:09:53 INFO - PID 3634 | async*exports.testTeardown@file:///tmp/tmpnBWgwx/profile/extensions/bug1150215@mozilla.org">bug1150215@mozilla.org/content/tests/head.js:46:10 12:09:53 INFO - PID 3634 | 12:09:53 INFO - Terminating psutil.Process(pid=3634, name='firefox-bin', started='12:08:54')
Flags: needinfo?(lsmyth)
Queued a new patch with fixes for the damp failure.
Flags: needinfo?(lsmyth)
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Attached patch 102-3.patch (deleted) — Splinter Review
Attachment #9026753 - Flags: review?(dwalsh)
Attachment #9026753 - Flags: review?(dwalsh) → review+
*** v102 originaly introduced a couple of regressions: == Change summary for alert #17641 (as of Fri, 16 Nov 2018 22:26:17 GMT) == Regressions: 192% damp custom.jsdebugger.stepIn.DAMP osx-10-10 opt e10s stylo 1,512.40 -> 4,422.60 163% damp custom.jsdebugger.stepIn.DAMP windows10-64 pgo e10s stylo 859.74 -> 2,257.67 146% damp custom.jsdebugger.stepIn.DAMP linux64-qr opt e10s stylo 894.28 -> 2,197.06 64% damp custom.jsdebugger.stepOver.DAMP windows10-64 pgo e10s stylo 253.38 -> 416.17 64% damp custom.jsdebugger.stepOut.DAMP osx-10-10 opt e10s stylo 1,136.51 -> 1,866.27 39% damp custom.jsdebugger.stepOver.DAMP osx-10-10 opt e10s stylo 455.14 -> 633.84 36% damp custom.jsdebugger.stepOver.DAMP linux64-qr opt e10s stylo 301.96 -> 409.73 33% damp custom.jsdebugger.stepOut.DAMP linux64-qr opt e10s stylo 620.23 -> 826.32 30% damp custom.jsdebugger.stepOut.DAMP windows10-64 pgo e10s stylo 593.36 -> 771.22 16% damp custom.jsdebugger.pause.DAMP osx-10-10 opt e10s stylo 706.59 -> 820.78 15% damp simple.jsdebugger.reload.DAMP osx-10-10 opt e10s stylo 407.35 -> 466.70 8% damp custom.jsdebugger.pause.DAMP windows10-64 pgo e10s stylo 343.71 -> 372.26 4% damp complicated.jsdebugger.open.DAMP osx-10-10 opt e10s stylo 2,680.86 -> 2,795.10 4% damp osx-10-10 opt e10s stylo 435.74 -> 451.08 3% damp complicated.jsdebugger.open.DAMP windows10-64 pgo e10s stylo 1,223.65 -> 1,264.25 3% damp custom.jsdebugger.open.DAMP osx-10-10 opt e10s stylo 1,752.57 -> 1,805.78 3% damp linux64-qr opt e10s stylo 235.19 -> 242.33 3% damp complicated.jsdebugger.reload.DAMP windows10-64 pgo e10s stylo 1,724.18 -> 1,771.10 2% damp windows10-64 pgo e10s stylo 205.97 -> 210.82 Improvements: 7% damp custom.jsdebugger.close.DAMP linux64-qr opt e10s stylo 50.84 -> 47.37 6% damp complicated.netmonitor.open.DAMP windows10-64 pgo e10s stylo 257.55 -> 242.71 For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=17641 *** The disabling of column breakpoint recovered from v102 regression for all but pause and step-out: == Change summary for alert #17763 (as of Thu, 22 Nov 2018 18:17:00 GMT) == Regressions: 18% damp custom.jsdebugger.stepOver.DAMP linux64 pgo e10s stylo 268.68 -> 316.61 16% damp custom.jsdebugger.stepOut.DAMP windows7-32 opt e10s stylo 796.03 -> 923.45 16% damp custom.jsdebugger.stepOut.DAMP windows10-64-qr opt e10s stylo 839.73 -> 970.59 14% damp console.typing windows7-32 opt e10s stylo 326.25 -> 372.52 12% damp custom.jsdebugger.stepOut.DAMP windows10-64 opt e10s stylo 855.53 -> 958.61 11% damp console.typing windows10-64 pgo e10s stylo 317.77 -> 353.42 11% damp console.typing linux64-qr opt e10s stylo 382.95 -> 424.06 8% damp simple.jsdebugger.close.DAMP windows10-64-qr opt e10s stylo 25.06 -> 27.04 7% damp custom.jsdebugger.close.DAMP linux64 opt e10s stylo 45.23 -> 48.28 7% damp custom.jsdebugger.stepOut.DAMP linux64-qr opt e10s stylo 816.68 -> 870.20 6% damp simple.jsdebugger.close.DAMP windows10-64 opt e10s stylo 27.63 -> 29.26 5% damp simple.jsdebugger.close.DAMP windows7-32 pgo e10s stylo 25.09 -> 26.43 5% damp custom.jsdebugger.close.DAMP windows10-64-qr opt e10s stylo 43.55 -> 45.83 5% damp complicated.netmonitor.open.DAMP windows10-64 pgo e10s stylo 243.06 -> 255.69 3% damp complicated.netmonitor.open.DAMP windows7-32 pgo e10s stylo 242.14 -> 249.73 3% damp custom.jsdebugger.close.DAMP windows7-32 opt e10s stylo 45.59 -> 46.86 Improvements: 68% damp custom.jsdebugger.stepIn.DAMP osx-10-10 opt e10s stylo 4,423.27 -> 1,425.99 61% damp custom.jsdebugger.stepIn.DAMP linux64 opt e10s stylo 2,165.83 -> 854.40 60% damp custom.jsdebugger.stepIn.DAMP linux64-qr opt e10s stylo 2,196.23 -> 887.74 59% damp custom.jsdebugger.stepIn.DAMP windows10-64 opt e10s stylo 2,432.70 -> 993.62 59% damp custom.jsdebugger.stepIn.DAMP windows10-64-qr opt e10s stylo 2,420.74 -> 991.79 59% damp custom.jsdebugger.stepIn.DAMP windows10-64 pgo e10s stylo 2,263.98 -> 929.60 58% damp custom.jsdebugger.stepIn.DAMP windows7-32 opt e10s stylo 2,253.50 -> 948.43 57% damp custom.jsdebugger.stepIn.DAMP linux64 pgo e10s stylo 2,030.20 -> 868.30 57% damp custom.jsdebugger.stepIn.DAMP windows7-32 pgo e10s stylo 2,061.45 -> 896.79 34% damp custom.jsdebugger.stepOver.DAMP windows10-64 pgo e10s stylo 426.25 -> 283.05 31% damp custom.jsdebugger.stepOut.DAMP osx-10-10 opt e10s stylo 1,886.88 -> 1,308.07 30% damp custom.jsdebugger.stepOver.DAMP windows10-64 opt e10s stylo 427.90 -> 299.92 29% damp custom.jsdebugger.stepOver.DAMP windows10-64-qr opt e10s stylo 432.99 -> 307.40 24% damp custom.jsdebugger.stepOver.DAMP linux64-qr opt e10s stylo 415.61 -> 314.03 24% damp custom.jsdebugger.stepOver.DAMP windows7-32 opt e10s stylo 393.72 -> 300.04 16% damp custom.jsdebugger.stepOut.DAMP windows7-32 pgo e10s stylo 755.64 -> 636.68 10% damp custom.jsdebugger.stepOut.DAMP linux64 pgo e10s stylo 696.96 -> 625.17 8% damp complicated.netmonitor.open.DAMP linux64 pgo e10s stylo 250.09 -> 231.07 5% damp custom.jsdebugger.pause.DAMP windows7-32 opt e10s stylo 423.42 -> 401.68 5% damp complicated.jsdebugger.open.DAMP windows10-64-qr opt e10s stylo 1,391.01 -> 1,321.00 5% damp custom.jsdebugger.pause.DAMP windows10-64 pgo e10s stylo 375.89 -> 357.46 5% damp custom.jsdebugger.close.DAMP linux64 pgo e10s stylo 44.06 -> 41.98 5% damp custom.jsdebugger.pause.DAMP windows7-32 pgo e10s stylo 381.29 -> 363.38 5% damp custom.jsdebugger.pause.DAMP windows10-64 opt e10s stylo 414.83 -> 395.43 5% damp complicated.jsdebugger.open.DAMP windows10-64 opt e10s stylo 1,366.63 -> 1,302.83 4% damp custom.jsdebugger.pause.DAMP linux64 pgo e10s stylo 352.61 -> 336.79 4% damp custom.jsdebugger.pause.DAMP windows10-64-qr opt e10s stylo 415.37 -> 397.06 4% damp custom.jsdebugger.pause.DAMP linux64-qr opt e10s stylo 446.47 -> 427.71 4% damp complicated.jsdebugger.open.DAMP linux64 opt e10s stylo 1,391.47 -> 1,342.00 3% damp complicated.jsdebugger.open.DAMP windows10-64 pgo e10s stylo 1,269.05 -> 1,229.39 3% damp complicated.jsdebugger.open.DAMP windows7-32 opt e10s stylo 1,281.37 -> 1,242.46 3% damp complicated.jsdebugger.open.DAMP linux64 pgo e10s stylo 1,277.80 -> 1,241.86 3% damp custom.jsdebugger.pause.DAMP linux64 opt e10s stylo 398.82 -> 387.75 3% damp complicated.jsdebugger.reload.DAMP windows10-64 pgo e10s stylo 1,799.16 -> 1,750.65 3% damp complicated.jsdebugger.open.DAMP windows7-32 pgo e10s stylo 1,200.92 -> 1,169.04 3% damp complicated.jsdebugger.reload.DAMP windows7-32 opt e10s stylo 1,898.15 -> 1,850.56 2% damp complicated.jsdebugger.open.DAMP linux64-qr opt e10s stylo 1,536.63 -> 1,499.48 2% damp complicated.jsdebugger.reload.DAMP windows7-32 pgo e10s stylo 1,761.39 -> 1,720.15 2% damp complicated.jsdebugger.reload.DAMP windows10-64 opt e10s stylo 1,922.54 -> 1,878.42 2% damp windows10-64 pgo e10s stylo 213.55 -> 208.86 2% damp complicated.jsdebugger.reload.DAMP linux64 pgo e10s stylo 1,598.06 -> 1,565.12 For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=17763 It is clearer to see that via the graphs: https://firefox-dev.tools/performance-dashboard/tools/debugger.html?days=14&filterstddev=true&ignoreFlags=true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: