Closed
Bug 1507344
Opened 6 years ago
Closed 6 years ago
Move LLVM_PROFDATA merge step into a more convenient place
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox66 fixed)
RESOLVED
FIXED
mozilla66
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: chmanchester, Assigned: chmanchester)
References
Details
Attachments
(2 files)
Right now this runs during the `maybe_clobber_profilebuild` step in the root Makefile.in. Merging the profile needs to happen in the second stage of the new PGO scheme so it would be more convenient to do this somewhere else, either as a part of a mozharness script or profileserver.py.
Comment 1•6 years ago
|
||
Note that we do currently use profileserver.py in the valgrind builds (just to have a fairly small test that actually runs Firefox).
Comment 2•6 years ago
|
||
Nevermind, I was wrong, we use mozrunner directly in the valgrind-test command:
https://dxr.mozilla.org/mozilla-central/rev/b0b856065d5b7ad2996f707e6e797d0d72afd803/build/valgrind/mach_commands.py#46
Comment 3•6 years ago
|
||
Per bug 1507346 comment 2 we'll probably need to do this in the final build step since the tools we use are host binaries, so they won't run on macos, for example.
Also on Windows the re-build will need cygprofile.txt from the profiling step.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → cmanchester
Assignee | ||
Comment 5•6 years ago
|
||
Assignee | ||
Comment 6•6 years ago
|
||
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3b1c7ad601ba
Add configure machinery for MOZ_PROFILE_USE and merging profile. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/df23b1fa16f5
Add a configure option for JARLOG_FILE in profile use builds. r=nalexander
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3b1c7ad601ba
https://hg.mozilla.org/mozilla-central/rev/df23b1fa16f5
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in
before you can comment on or make changes to this bug.
Description
•