Closed
Bug 1507635
Opened 6 years ago
Closed 6 years ago
Running reftest/crashtest tests in isolation from 'mach try fuzzy' doesn't work
Categories
(Testing :: General, defect, P3)
Testing
General
Tracking
(firefox65 fixed)
RESOLVED
FIXED
mozilla65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: marco, Assigned: marco)
References
(Blocks 1 open bug)
Details
Attachments
(4 files)
(deleted),
application/x-xz
|
Details | |
(deleted),
patch
|
ahal
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
ahal
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
ahal
:
review+
|
Details | Diff | Splinter Review |
./mach try fuzzy layout/reftests/css-ruby/nested-ruby-1.html layout/reftests/w3c-css/submitted/counter-styles-3/disclosure-styles.html
The failure is:
> runreftest.py: error: unrecognized arguments: -- tests/reftest/tests/layout/reftests/reftest.list
Assignee | ||
Comment 1•6 years ago
|
||
After bug 1507767 is fixed, crashtests can be scheduled but they fail with a similar error:
> runreftest.py: error: unrecognized arguments: -- tests/reftest/tests/testing/crashtest/crashtests.list
Updated•6 years ago
|
Priority: -- → P3
Summary: Running reftest tests in isolation doesn't work → Running reftest tests in isolation from 'mach try fuzzy' doesn't work
Assignee | ||
Updated•6 years ago
|
Summary: Running reftest tests in isolation from 'mach try fuzzy' doesn't work → Running reftest/crashtest tests in isolation from 'mach try fuzzy' doesn't work
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → mcastelluccio
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•6 years ago
|
||
This is the first step to make this work. After applying this, reftests start but fail very early with:
> ERROR - REFTEST ERROR | Exactly one of reftest.manifests or reftest.tests must be specified.
Assignee | ||
Comment 3•6 years ago
|
||
Attachment #9026134 -
Flags: review?(ahal)
Assignee | ||
Comment 4•6 years ago
|
||
Attachment #9026136 -
Flags: review?(ahal)
Assignee | ||
Updated•6 years ago
|
Attachment #9026096 -
Flags: review?(ahal)
Comment 5•6 years ago
|
||
Comment on attachment 9026134 [details] [diff] [review]
Log reftest.manifests and reftest.tests when there is an error with them
Review of attachment 9026134 [details] [diff] [review]:
-----------------------------------------------------------------
::: layout/tools/reftest/reftest.jsm
@@ +363,4 @@
>
> if ((testList && manifests) || !(testList || manifests)) {
> logger.error("Exactly one of reftest.manifests or reftest.tests must be specified.");
> + logger.debug("reftest.manifests is: " + manifests);
Did you mean to make this debug?
Attachment #9026134 -
Flags: review?(ahal) → review+
Comment 6•6 years ago
|
||
Comment on attachment 9026136 [details] [diff] [review]
reftest paths should be relative to abs_reftest_dir/tests
Review of attachment 9026136 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks for catching and fixing this!
Attachment #9026136 -
Flags: review?(ahal) → review+
Updated•6 years ago
|
Attachment #9026096 -
Flags: review?(ahal) → review+
Pushed by mcastelluccio@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ab36ef2d6d00
When running specific tests on try, don't use the 'tests' attribute from the suite. r=ahal
https://hg.mozilla.org/integration/mozilla-inbound/rev/8b24e89c77f1
Log reftest.manifests and reftest.tests when there is an error with them. r=ahal
https://hg.mozilla.org/integration/mozilla-inbound/rev/da7bf8203ec1
reftest paths should be relative to abs_reftest_dir/tests. r=ahal
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ab36ef2d6d00
https://hg.mozilla.org/mozilla-central/rev/8b24e89c77f1
https://hg.mozilla.org/mozilla-central/rev/da7bf8203ec1
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Comment 9•6 years ago
|
||
bugherder uplift |
status-firefox-esr60:
--- → fixed
Updated•6 years ago
|
status-firefox-esr60:
fixed → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•