Closed Bug 1507741 Opened 6 years ago Closed 6 years ago

Background pattern can be placed way outside of the actual element

Categories

(DevTools :: Inspector, defect, P2)

65 Branch
defect

Tracking

(firefox65 verified)

VERIFIED FIXED
Firefox 65
Tracking Status
firefox65 --- verified

People

(Reporter: mbalfanz, Assigned: pbro)

References

(Depends on 1 open bug)

Details

Attachments

(4 files)

Attached video misplaced-highlighter.mp4 (deleted) —
STR: - visit https://labs.jensimmons.com/2017/02-010.html - open the inspector, and select for example `.auto > div:nth-child(3)` - enable the flex highlighter - scroll the page down until `.none > div:nth-child(4)` ER: - the highlighter, incl. background pattern, should show up on the selected element AR: - parts of the highlighter show up somewhere else on the page The attached video shows another example.
This seems to be working fine since at least bug 1499630. We should retest once that bug lands.
Depends on: 1499630
@Martin Can you test this on the latest nightly?
Flags: needinfo?(mbalfanz)
Can still reproduce it on latest m-c.
Flags: needinfo?(mbalfanz)
Ironically, IT made me send my 4K screen back to them a month or two back because "I didn't need it." Now I am unable to reproduce the issue because I don't have a 4K screen. Anyhow, I think the cause is the canvas itself moving around... in this case whilst still drawing the highlight. Bug 1509071 should fix this.
Attached image Capture.PNG (deleted) —
Happens to me too on windows 10 with an external monitor (same as Martin's). Though it's not as bad as in Martin's video. For me the justify content area gets incorrectly placed by ~20px or so.
Attached video pattern-follow.mp4 (deleted) —
I noticed another thing about the misplaced pattern: it follows on horizontal scroll, while the outline does not. See video attached.
Priority: -- → P2
I can totally reproduce this without a big screen. This just happened to me on https://labs.jensimmons.com/2017/02-010.html, on my macBook 12'' laptop screen, on the element section.none > div.flex
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
Pushed by pbrosset@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b89aa42e2fae take zoom and dpr into account when rendering justify-content; r=miker
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Flags: qe-verify+

I reproduced this issue using 65.0a1(2018-11-16) on macOS 10.13.
I can confirm this issue is fixed, I verified using Fx 65.0b10 on Windows 10 x64, macOS 10.13 and Ubuntu 16.04 LTS.
Cheers!

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: