Closed
Bug 1507950
Opened 6 years ago
Closed 6 years ago
Allow calling ReadableStream controller.error() more than once
Categories
(Core :: JavaScript Engine, enhancement, P2)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: jorendorff, Assigned: jorendorff)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
The spec has changed since we implemented it. We're too strict now; this causes some test failures in testing/web-platform/tests/streams/readable-streams/bad-underlying-sources*.html.
|
Assignee | |
Updated•6 years ago
|
Summary: Allow calling ReadableStream controller.close() more than once → Allow calling ReadableStream controller.error() more than once
|
|
Assignee | |
Comment 1•6 years ago
|
||
This is probably also causing the failures in testing/web-platform/tests/streams/readable-streams/garbage-collection*.html .
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → jorendorff
|
|
Assignee | |
Comment 2•6 years ago
|
||
|
|
Assignee | |
Comment 3•6 years ago
|
||
Pushed by jorendorff@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bc83a2fe5c17
Allow calling controller.error() when the stream is not readable. r=arai
Backout by dluca@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7eb42458e2d8
Backed out 5 changesets (bug 1507950, bug 1503012, bug 1507943, bug 1512050, bug 1512008) for spidermonkey and jit failures
Pushed by jorendorff@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a6eb6e3732ae
Allow calling controller.error() when the stream is not readable. r=arai
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
|
||
Updated•6 years ago
|
Keywords: dev-doc-needed
|
|
||
Comment 8•6 years ago
|
||
Note to MDN writers:
I'm not convinced this desparately needs to be added to the release notes, given that readable streams have only been enabled by default anyway. I think this just needs us to check whether the readable stream controller docs report the .error() behavior accurately.
|
|
||
Comment 9•6 years ago
|
||
I've documented this by adding a note to the error() page:
https://developer.mozilla.org/en-US/docs/Web/API/ReadableStreamDefaultController/error
I didn't think it was worth calling this out specifically in the compat data because it was only enabled by default in Firefox 65 anyway.
Let me know if that's OK. thanks!
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•